FF141 adds HTML popover source + force option #27157
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2431,7 +2431,7 @@ | |
| "chrome_android": "mirror", | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "141" | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "oculus": "mirror", | ||
|
|
@@ -2448,7 +2448,7 @@ | |
| "webview_ios": "mirror" | ||
| }, | ||
| "status": { | ||
| "experimental": false, | ||
| "standard_track": true, | ||
| "deprecated": false | ||
| } | ||
|
|
@@ -2467,7 +2467,7 @@ | |
| "chrome_android": "mirror", | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "141" | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "oculus": "mirror", | ||
|
|
@@ -2482,7 +2482,7 @@ | |
| "webview_ios": "mirror" | ||
| }, | ||
| "status": { | ||
| "experimental": false, | ||
| "standard_track": true, | ||
| "deprecated": false | ||
| } | ||
|
|
@@ -2862,6 +2862,41 @@ | |
| "deprecated": false | ||
| } | ||
| }, | ||
| "force": { | ||
| "__compat": { | ||
| "description": "`force` option", | ||
| "spec_url": "https://html.spec.whatwg.org/multipage/dom.html#dom-togglepopoveroptions-force", | ||
| "tags": [ | ||
| "web-features:popover" | ||
| ], | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": false | ||
|
||
| }, | ||
| "chrome_android": "mirror", | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "141" | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "oculus": "mirror", | ||
| "opera": "mirror", | ||
| "opera_android": "mirror", | ||
| "safari": { | ||
| "version_added": false | ||
| }, | ||
| "safari_ios": "mirror", | ||
| "samsunginternet_android": "mirror", | ||
| "webview_android": "mirror", | ||
| "webview_ios": "mirror" | ||
| }, | ||
| "status": { | ||
| "experimental": true, | ||
| "standard_track": true, | ||
| "deprecated": false | ||
| } | ||
| } | ||
| }, | ||
| "returns_boolean": { | ||
| "__compat": { | ||
| "description": "Returns `true` or `false`", | ||
|
|
@@ -2912,7 +2947,7 @@ | |
| "chrome_android": "mirror", | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "141" | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "oculus": "mirror", | ||
|
|
@@ -2929,7 +2964,7 @@ | |
| "webview_ios": "mirror" | ||
| }, | ||
| "status": { | ||
| "experimental": false, | ||
| "standard_track": true, | ||
| "deprecated": false | ||
| } | ||
|
|
@@ -2948,7 +2983,7 @@ | |
| "chrome_android": "mirror", | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "141" | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "oculus": "mirror", | ||
|
|
@@ -2963,7 +2998,7 @@ | |
| "webview_ios": "mirror" | ||
| }, | ||
| "status": { | ||
| "experimental": false, | ||
| "standard_track": true, | ||
| "deprecated": false | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied the pattern of
source.For both this and
sourceshouldn't the actual pattern be as below, based on the schema? Or did that change?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that
forcecan be both a parameter and an option, and the option came later, we might want to record it as bothforce_parameterandforce_option, to avoid confusion.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. That is absolutely the right thing to do. I have changed this to match the expected schema and key names.
PS Thanks for doing the research on when these were introduced in chrome/safari