docs(xss): clarify attribute-context examples and fix contradiction #40786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badwriter123
requested review from
hamishwillee
and removed request for
a team
github-actions
bot
added
Content:Security
Contributor
|
Preview URLs (comment last updated: 2025-08-18 23:35:58) |
github-actions
bot
added
size/s
hamishwillee
approved these changes
Aug 18, 2025
Collaborator
hamishwillee
left a comment
hamishwillee
left a comment
There was a problem hiding this comment.
Thank you. I think this is better.
estelle
pushed a commit
that referenced
this pull request
Aug 19, 2025
…40786) * docs(xss): clarify attribute-context examples and fix contradiction * Update files/en-us/web/security/attacks/xss/index.md --------- Co-authored-by: Hamish Willee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (#40780)
Hello,
For the file --> files/en-us/web/security/attacks/xss/index.md , I fixed the contradiction in the “Document contexts” section. I have updated the example to use a working payload (onmouseover=alert(1) or backticks). I also corrected the unquoted class example to demonstrate real attribute injection and specified that quoting the placeholder prevents it. No other sections were changed.
Motivation
I wanted to remove the contradiction and make the examples accurate and unambiguous.