Skip to content

Conversation

microbit-robert
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Aug 8, 2022

Deploy Preview for distracted-dubinsky-fd8a42 ready!

Name Link
🔨 Latest commit 5172646
🔍 Latest deploy log https://app.netlify.com/sites/distracted-dubinsky-fd8a42/deploys/62f2502b58fbab000838fee2
😎 Deploy Preview https://deploy-preview-26--distracted-dubinsky-fd8a42.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@microbit-robert
Copy link
Contributor Author

@microbit-matt-hillsdon Let's discuss the comments in microbithal_js.c for the microphone functions to make sure I've not missed anything important.

@microbit-matt-hillsdon
Copy link
Contributor

I accidentally broke this because I didn't realise that 0,1 and 1,2 are both used to represent quiet/low and loud/high.
If this PR is merged then we can just bump MicroPython, otherwise we need a different conversion for the 0,1 case (set_threshold).

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 4b0f0d3 into main Aug 9, 2022
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the microphone branch August 9, 2022 12:21
@microbit-matt-hillsdon
Copy link
Contributor

I accidentally broke this because I didn't realise that 0,1 and 1,2 are both used to represent quiet/low and loud/high. If this PR is merged then we can just bump MicroPython, otherwise we need a different conversion for the 0,1 case (set_threshold).

Put in a workaround on the assumption we'll merge this. If not I'll redo to have separate conversions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants