microbit_hal: Consistent values for mic levels #109
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAL implementers need to work with both microbit_hal_level_detector_callback and microbit_hal_microphone_set_threshold. It's confusing for the former to use 1 and 2 and the latter 0 and 1 to represent low and high. Consistently use 1 and 2 via the HAL defines.
microbit-matt-hillsdon
added a commit
to microbit-foundation/micropython-microbit-v2-simulator
that referenced
this pull request
Aug 9, 2022
microbit-matt-hillsdon
pushed a commit
to microbit-foundation/micropython-microbit-v2-simulator
that referenced
this pull request
Aug 9, 2022
Includes temporary workaround for inconsistent values in the hal to represent thresholds. See microbit-foundation/micropython-microbit-v2#109
|
Instead of this I think we should make two new defines to set the threshold (the existing ones are event numbers), because these two sets are conceptually independent. Eg: #define MICROBIT_HAL_MICROPHONE_SET_THRESHOLD_LOW (0)
#define MICROBIT_HAL_MICROPHONE_SET_THRESHOLD_HIGH (1)And probably rename the existing ones to: #define MICROBIT_HAL_MICROPHONE_EVT_THRESHOLD_LOW (1)
#define MICROBIT_HAL_MICROPHONE_EVT_THRESHOLD_HIGH (2) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HAL implementers need to work with both
microbit_hal_level_detector_callback and
microbit_hal_microphone_set_threshold. It's confusing for the former to
use 1 and 2 and the latter 0 and 1 to represent low and high.
Consistently use 1 and 2 via the HAL defines.