Skip to content
This repository was archived by the owner on Aug 22, 2024. It is now read-only.

User/jonsanto/task5501 fix broken linux build #1497

Closed
wants to merge 61 commits into from
Closed

User/jonsanto/task5501 fix broken linux build #1497

wants to merge 61 commits into from

Conversation

@JonathanESantos
Copy link
Contributor

@JonathanESantos JonathanESantos commented Jan 29, 2021

Fixes #5501

Description of the changes:

  • Fix code that broke compilation in Ubuntu 18.04.
  • Note that there is a delta outside of these code changes that broke the k4aviewer. Will need to investigate.

Before submitting a Pull Request:

I tested changes on:

  • Windows
  • Linux

AntonClaytonBursch and others added 30 commits November 5, 2020 18:26
@AntonClaytonBursch
Add K4A_RESULT_UNSUPPORTED to result enums.
f7686a9
@AntonClaytonBursch
Structs for device, color, depth. Enum for calibration. Functions to …
70eaf43 
…get mode for color and depth.
@AntonClaytonBursch
Updates examples, src, tests and tools to use new config and color an…
143cd46 
…d depth modes.
@AntonClaytonBursch
Added fps mode structs and functions.
7496015
@AntonClaytonBursch
Updated code to reflect change to using fps mode.
163d176
@AntonClaytonBursch
Moded color, depth and fps enums from k4a/k4atypes.h to k4ainternal/m…
bdb2ed3 
…odes.h
@AntonClaytonBursch
Updated c++ wrapper to use new color and depth modes.
dc0db6b
@AntonClaytonBursch
Updated C++ wrapper with get device, depth, color and fps functions. …
b7de2fb 
…Added to device class.
@AntonClaytonBursch
Update k4arecord/types.h and examples to use color, depth and fps mod…
f9dda0a 
…es instead of enums.
@AntonClaytonBursch
added depth range to k4a_depth_mode_info, updated get color/depth/fps…
051f8eb 
… count functions, refactored k4astaticimageproperties
@AntonClaytonBursch
Update k4astaticimageproperties.h to use k4a.hpp instead of k4a.h
14ccb08
@AntonClaytonBursch
Quick fix: forgot to add K4A_EXPORT to get mode and mode count functi…
4bc4c00 
…ons in k4a.h
@AntonClaytonBursch
examples, tests, tools refactored to use new get mode functions
e3d04a3
@AntonClaytonBursch
quick comments fix in calibration example and updates to color_ft tes…
9ceb3e1 
…ts to use new get mode functions
@AntonClaytonBursch
Changed get modes loops for fps, color and depth.
b5b3806
@AntonClaytonBursch
Viewer mode selection from radio to comboboxes
33c964f
@AntonClaytonBursch
using mode info types instead of mode info type index
fcac45f
@AntonClaytonBursch
refactor to use mode info instead of mode id
eed589a
@AntonClaytonBursch
using depth/color/fps mode info instead of mode id
fc655bd
@AntonClaytonBursch
mode id changes and GUI cleanup
a85ed66
@AntonClaytonBursch
revert back from using device mode info to device mode id for fps/col…
9c97825 
…or/depth modes
@AntonClaytonBursch
Use constants defined in usb_cmd_priv.h to set the vendor id and devi…
a488ed1 
…ce id in device get info in k4a.c
@AntonClaytonBursch
Used const for color/depth/fps mode info initializers.
0289b22
@AntonClaytonBursch
Passing depth mode info down to point cloud viewer. Moved static k4a …
01893b2 
…color/depth/fps mode arrays into modes.h.
@AntonClaytonBursch
color, depth and fps mode infos saved in and parsed from recordings
a1b772d
@AntonClaytonBursch
Initialize the size and version of the mode structs
158b641
@AntonClaytonBursch
Moved K4A_MSFT_VID, K4A_RGB_PID and K4A_DEPTH_PID to usbcommand.h. Ad…
66bc1e5 
…ding device info to recordings.
@AntonClaytonBursch
error handling for saving modes and device info in recording
2a70cd1
@AntonClaytonBursch
color, depth, fps mode info and device info saved in and parse from r…
5f99801 
…ecordings
@JonathanESantos
Fixing K4A build errors in src/record/internal/matroska_read.cpp abou…
af6d217 
…t not being able to convert from float to enum, and in tools/k4aviewer/k4arecordingdockcontrol.cpp about mismatched signed/unsigned comparison.

The rest of the changes are formatting enforced by clang with the command line command "ninja clangformat". The command line build enforces this step before building.

Fixed Bug 5456.
JonathanESantos and others added 28 commits January 26, 2021 14:25
@JonathanESantos
K4A API: Adding to docstrings that functions may return status of UNS…
e8fe464 
…UPPORTED for devices that choose not to support that operation.
@AntonClaytonBursch
linked k4a_math in viewer
d592958
@AntonClaytonBursch
Recording description from mode info saved in recording (or legacy de…
5d51a26 
…fauts).
@AntonClaytonBursch
Merge pull request #3 from AntonClaytonBursch/user/jonsanto/Task5460_…
e3bfdb2 
…AddCommentsRegardingUnsupportedFunctions

K4A API: Adding to docstrings that functions may return status of UNS…
@AntonClaytonBursch
Use modes for k4arecorder
81b9de6
@AntonClaytonBursch
Recorder mode option listed.
7a91853
@AntonClaytonBursch
Merge branch 'api-update' of https://github.com/AntonClaytonBursch/Az…
1bc8889 
…ure-Kinect-Sensor-SDK into api-update
@JonathanESantos
k4aviewer: Removing audio support. To turn on audio support, in tools…
162a016 
…/k4aviewer/CMakeLists.txt, set K4A_INCLUDE_AUDIO to 1.
@JonathanESantos
k4aviewer: Removing support for audio and clangformat wants to format…
1ccc23f 
… one file a certain way.
@AntonClaytonBursch
working on recorder command line validation
a828c1e
@JonathanESantos
Merge branch 'api-update' into user/jonsanto/Task5467_RemoveSupportFo…
5be389d 
…rMicrophone
@JonathanESantos
k4arecorder: Minor editing.
46e53da
@JonathanESantos
k4a: Adding functional tests for calling the added functions in k4a.h.
b493720
@JonathanESantos
Removing commented-out code.
b32f3ac
@JonathanESantos
k4a: Fixing a test in depth_ft.
6d28e16
@JonathanESantos
Update main.cpp
e8c0f22
@JonathanESantos
Update main.cpp
c7279c3
@JonathanESantos
Update main.cpp
da96ffc
@JonathanESantos
Update main.cpp
235ba8f
@JonathanESantos
Update main.cpp
8d2a3b1
@AntonClaytonBursch
Merge pull request #5 from AntonClaytonBursch/user/jonsanto/Task5466_…
fa07ae8 
…CreateTestsForAPIUpdates

User/jonsanto/task5466 create tests for api updates
@AntonClaytonBursch
validate recorder cmd options
df3b755
@AntonClaytonBursch
finished validating recording cmd options
f82b42d
@AntonClaytonBursch
Fixed get fps mode in recorder.
1166777
@AntonClaytonBursch
Merge branch 'api-update' into user/jonsanto/Task5467_RemoveSupportFo…
bab38b8 
…rMicrophone
@AntonClaytonBursch
Merge pull request #4 from AntonClaytonBursch/user/jonsanto/Task5467_…
d9f616d 
…RemoveSupportForMicrophone

User/jonsanto/task5467 remove support for microphone
@JonathanESantos
Fix broken Linux build.
a5f6512
@JonathanESantos
k4a: ninja clangformat made these formatting changes.
b4df263
@JonathanESantos
Copy link
Contributor Author

JonathanESantos commented Jan 29, 2021

Wrong target.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JonathanESantos @AntonClaytonBursch