Skip to content
This repository was archived by the owner on Aug 22, 2024. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
f7686a9
Add K4A_RESULT_UNSUPPORTED to result enums.
AntonClaytonBursch Nov 6, 2020
70eaf43
Structs for device, color, depth. Enum for calibration. Functions to …
AntonClaytonBursch Nov 11, 2020
143cd46
Updates examples, src, tests and tools to use new config and color an…
AntonClaytonBursch Nov 11, 2020
7496015
Added fps mode structs and functions.
AntonClaytonBursch Nov 11, 2020
163d176
Updated code to reflect change to using fps mode.
AntonClaytonBursch Nov 11, 2020
bdb2ed3
Moded color, depth and fps enums from k4a/k4atypes.h to k4ainternal/m…
AntonClaytonBursch Nov 13, 2020
dc0db6b
Updated c++ wrapper to use new color and depth modes.
AntonClaytonBursch Nov 17, 2020
b7de2fb
Updated C++ wrapper with get device, depth, color and fps functions. …
AntonClaytonBursch Nov 17, 2020
f9dda0a
Update k4arecord/types.h and examples to use color, depth and fps mod…
AntonClaytonBursch Nov 19, 2020
051f8eb
added depth range to k4a_depth_mode_info, updated get color/depth/fps…
AntonClaytonBursch Nov 23, 2020
14ccb08
Update k4astaticimageproperties.h to use k4a.hpp instead of k4a.h
AntonClaytonBursch Nov 23, 2020
4bc4c00
Quick fix: forgot to add K4A_EXPORT to get mode and mode count functi…
AntonClaytonBursch Nov 23, 2020
e3d04a3
examples, tests, tools refactored to use new get mode functions
AntonClaytonBursch Nov 30, 2020
9ceb3e1
quick comments fix in calibration example and updates to color_ft tes…
AntonClaytonBursch Dec 3, 2020
b5b3806
Changed get modes loops for fps, color and depth.
AntonClaytonBursch Dec 9, 2020
33c964f
Viewer mode selection from radio to comboboxes
AntonClaytonBursch Dec 17, 2020
fcac45f
using mode info types instead of mode info type index
AntonClaytonBursch Dec 30, 2020
eed589a
refactor to use mode info instead of mode id
AntonClaytonBursch Dec 31, 2020
fc655bd
using depth/color/fps mode info instead of mode id
AntonClaytonBursch Jan 4, 2021
a85ed66
mode id changes and GUI cleanup
AntonClaytonBursch Jan 5, 2021
9c97825
revert back from using device mode info to device mode id for fps/col…
AntonClaytonBursch Jan 11, 2021
a488ed1
Use constants defined in usb_cmd_priv.h to set the vendor id and devi…
AntonClaytonBursch Jan 13, 2021
0289b22
Used const for color/depth/fps mode info initializers.
AntonClaytonBursch Jan 14, 2021
01893b2
Passing depth mode info down to point cloud viewer. Moved static k4a…
AntonClaytonBursch Jan 19, 2021
a1b772d
color, depth and fps mode infos saved in and parsed from recordings
AntonClaytonBursch Jan 20, 2021
158b641
Initialize the size and version of the mode structs
AntonClaytonBursch Jan 22, 2021
66bc1e5
Moved K4A_MSFT_VID, K4A_RGB_PID and K4A_DEPTH_PID to usbcommand.h. A…
AntonClaytonBursch Jan 22, 2021
2a70cd1
error handling for saving modes and device info in recording
AntonClaytonBursch Jan 22, 2021
5f99801
color, depth, fps mode info and device info saved in and parse from r…
AntonClaytonBursch Jan 22, 2021
af6d217
Fixing K4A build errors in src/record/internal/matroska_read.cpp abou…
JonathanESantos Jan 26, 2021
c541fde
SDK: docstring changes for Doxygen to run without errors.
JonathanESantos Jan 26, 2021
7a7854a
Merge pull request #1 from AntonClaytonBursch/user/jonsanto/Bug5456_F…
AntonClaytonBursch Jan 26, 2021
8f573d2
Merge pull request #2 from AntonClaytonBursch/user/jonsanto/Story5373…
AntonClaytonBursch Jan 26, 2021
e8fe464
K4A API: Adding to docstrings that functions may return status of UNS…
JonathanESantos Jan 26, 2021
d592958
linked k4a_math in viewer
AntonClaytonBursch Jan 26, 2021
5d51a26
Recording description from mode info saved in recording (or legacy de…
AntonClaytonBursch Jan 26, 2021
e3bfdb2
Merge pull request #3 from AntonClaytonBursch/user/jonsanto/Task5460_…
AntonClaytonBursch Jan 26, 2021
81b9de6
Use modes for k4arecorder
AntonClaytonBursch Jan 27, 2021
7a91853
Recorder mode option listed.
AntonClaytonBursch Jan 27, 2021
1bc8889
Merge branch 'api-update' of https://github.com/AntonClaytonBursch/Az…
AntonClaytonBursch Jan 27, 2021
162a016
k4aviewer: Removing audio support. To turn on audio support, in tools…
JonathanESantos Jan 27, 2021
1ccc23f
k4aviewer: Removing support for audio and clangformat wants to format…
JonathanESantos Jan 27, 2021
a828c1e
working on recorder command line validation
AntonClaytonBursch Jan 27, 2021
5be389d
Merge branch 'api-update' into user/jonsanto/Task5467_RemoveSupportFo…
JonathanESantos Jan 27, 2021
46e53da
k4arecorder: Minor editing.
JonathanESantos Jan 27, 2021
b493720
k4a: Adding functional tests for calling the added functions in k4a.h.
JonathanESantos Jan 28, 2021
b32f3ac
Removing commented-out code.
JonathanESantos Jan 28, 2021
6d28e16
k4a: Fixing a test in depth_ft.
JonathanESantos Jan 28, 2021
e8c0f22
Update main.cpp
JonathanESantos Jan 28, 2021
c7279c3
Update main.cpp
JonathanESantos Jan 28, 2021
da96ffc
Update main.cpp
JonathanESantos Jan 28, 2021
235ba8f
Update main.cpp
JonathanESantos Jan 28, 2021
8d2a3b1
Update main.cpp
JonathanESantos Jan 28, 2021
fa07ae8
Merge pull request #5 from AntonClaytonBursch/user/jonsanto/Task5466_…
AntonClaytonBursch Jan 28, 2021
df3b755
validate recorder cmd options
AntonClaytonBursch Jan 28, 2021
f82b42d
finished validating recording cmd options
AntonClaytonBursch Jan 28, 2021
1166777
Fixed get fps mode in recorder.
AntonClaytonBursch Jan 28, 2021
bab38b8
Merge branch 'api-update' into user/jonsanto/Task5467_RemoveSupportFo…
AntonClaytonBursch Jan 28, 2021
d9f616d
Merge pull request #4 from AntonClaytonBursch/user/jonsanto/Task5467_…
AntonClaytonBursch Jan 28, 2021
a5f6512
Fix broken Linux build.
JonathanESantos Jan 29, 2021
b4df263
k4a: ninja clangformat made these formatting changes.
JonathanESantos Jan 29, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update k4arecord/types.h and examples to use color, depth and fps mod…
…es instead of enums.
  • Loading branch information
AntonClaytonBursch committed Nov 19, 2020
commit f9dda0abf291bfe89511a691050fc879568d44ba
6 changes: 3 additions & 3 deletions examples/calibration/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@ static void print_calibration()

k4a_device_configuration_t deviceConfig = K4A_DEVICE_CONFIG_INIT_DISABLE_ALL;
deviceConfig.color_format = K4A_IMAGE_FORMAT_COLOR_MJPG;
deviceConfig.color_mode_id = K4A_COLOR_RESOLUTION_1080P;
deviceConfig.depth_mode_id = K4A_DEPTH_MODE_NFOV_UNBINNED;
deviceConfig.fps_mode_id = K4A_FRAMES_PER_SECOND_30;
deviceConfig.color_mode_id = 2; // K4A_COLOR_RESOLUTION_1080P
deviceConfig.depth_mode_id = 2; // K4A_DEPTH_MODE_NFOV_UNBINNED
deviceConfig.fps_mode_id = 2; // K4A_FRAMES_PER_SECOND_30
deviceConfig.wired_sync_mode = K4A_WIRED_SYNC_MODE_STANDALONE;
deviceConfig.synchronized_images_only = true;

Expand Down
4 changes: 2 additions & 2 deletions examples/fastpointcloud/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,8 @@ int main(int argc, char **argv)
goto Exit;
}

config.depth_mode_id = K4A_DEPTH_MODE_WFOV_2X2BINNED;
config.fps_mode_id = K4A_FRAMES_PER_SECOND_30;
config.depth_mode_id = 3; // K4A_DEPTH_MODE_WFOV_2X2BINNED
config.fps_mode_id = 2; // K4A_FRAMES_PER_SECOND_30

k4a_calibration_t calibration;
if (K4A_RESULT_SUCCEEDED !=
Expand Down
6 changes: 3 additions & 3 deletions examples/green_screen/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -515,9 +515,9 @@ static k4a_device_configuration_t get_default_config()
{
k4a_device_configuration_t camera_config = K4A_DEVICE_CONFIG_INIT_DISABLE_ALL;
camera_config.color_format = K4A_IMAGE_FORMAT_COLOR_BGRA32;
camera_config.color_resolution = K4A_COLOR_RESOLUTION_720P;
camera_config.depth_mode = K4A_DEPTH_MODE_WFOV_UNBINNED; // No need for depth during calibration
camera_config.camera_fps = K4A_FRAMES_PER_SECOND_15; // Don't use all USB bandwidth
camera_config.color_mode_id = 1; // K4A_COLOR_RESOLUTION_720P
camera_config.depth_mode_id = 4; // K4A_DEPTH_MODE_WFOV_UNBINNED // No need for depth during calibration
camera_config.fps_mode_id = 1; // K4A_FRAMES_PER_SECOND_15 // Don't use all USB bandwidth
camera_config.subordinate_delay_off_master_usec = 0; // Must be zero for master
camera_config.synchronized_images_only = true;
return camera_config;
Expand Down
6 changes: 3 additions & 3 deletions examples/k4arecord_custom_track/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ int main(int argc, char **argv)
char *recording_filename = argv[1];

k4a_device_configuration_t device_config = K4A_DEVICE_CONFIG_INIT_DISABLE_ALL;
device_config.depth_mode_id = K4A_DEPTH_MODE_NFOV_UNBINNED;
device_config.fps_mode_id = K4A_FRAMES_PER_SECOND_30;
device_config.depth_mode_id = 2; // K4A_DEPTH_MODE_NFOV_UNBINNED
device_config.fps_mode_id = 2; // K4A_FRAMES_PER_SECOND_30

k4a_device_t device;
VERIFY(k4a_device_open(0, &device));
Expand Down Expand Up @@ -90,7 +90,7 @@ int main(int argc, char **argv)
// Add a custom video track to store processed depth images.
// Read the depth resolution from the camera configuration so we can create our custom track with the same size.
k4a_calibration_t sensor_calibration;
VERIFY(k4a_device_get_calibration(device, device_config.depth_mode_id, K4A_COLOR_RESOLUTION_OFF, &sensor_calibration));
VERIFY(k4a_device_get_calibration(device, device_config.depth_mode_id, 0, &sensor_calibration)); // K4A_COLOR_RESOLUTION_OFF
uint32_t depth_width = (uint32_t)sensor_calibration.depth_camera_calibration.resolution_width;
uint32_t depth_height = (uint32_t)sensor_calibration.depth_camera_calibration.resolution_height;

Expand Down
6 changes: 3 additions & 3 deletions examples/streaming/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ int main(int argc, char **argv)

k4a_device_configuration_t config = K4A_DEVICE_CONFIG_INIT_DISABLE_ALL;
config.color_format = K4A_IMAGE_FORMAT_COLOR_MJPG;
config.color_mode_id = K4A_COLOR_RESOLUTION_2160P;
config.depth_mode_id = K4A_DEPTH_MODE_NFOV_UNBINNED;
config.fps_mode_id = K4A_FRAMES_PER_SECOND_30;
config.color_mode_id = 5; // K4A_COLOR_RESOLUTION_2160P
config.depth_mode_id = 2; // K4A_DEPTH_MODE_NFOV_UNBINNED
config.fps_mode_id = 2; // K4A_FRAMES_PER_SECOND_30

if (K4A_RESULT_SUCCEEDED != k4a_device_start_cameras(device, &config))
{
Expand Down
6 changes: 3 additions & 3 deletions examples/transformation/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,9 @@ static int capture(std::string output_dir, uint8_t deviceId = K4A_DEVICE_DEFAULT
}

config.color_format = K4A_IMAGE_FORMAT_COLOR_BGRA32;
config.color_mode_id = K4A_COLOR_RESOLUTION_720P;
config.depth_mode_id = K4A_DEPTH_MODE_NFOV_UNBINNED;
config.fps_mode_id = K4A_FRAMES_PER_SECOND_30;
config.color_mode_id = 1; // K4A_COLOR_RESOLUTION_720P
config.depth_mode_id = 2; // K4A_DEPTH_MODE_NFOV_UNBINNED
config.fps_mode_id = 2; // K4A_FRAMES_PER_SECOND_30
config.synchronized_images_only = true; // ensures that depth and color images are both available in the capture

k4a_calibration_t calibration;
Expand Down
4 changes: 2 additions & 2 deletions examples/undistort/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -377,8 +377,8 @@ int main(int argc, char **argv)
goto Exit;
}

config.depth_mode_id = K4A_DEPTH_MODE_WFOV_2X2BINNED;
config.fps_mode_id = K4A_FRAMES_PER_SECOND_30;
config.depth_mode_id = 3; // K4A_DEPTH_MODE_WFOV_2X2BINNED
config.fps_mode_id = 2; // K4A_FRAMES_PER_SECOND_30

k4a_calibration_t calibration;
if (K4A_RESULT_SUCCEEDED !=
Expand Down
12 changes: 6 additions & 6 deletions examples/viewer/opengl/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ int main()
// Start the device
//
k4a_device_configuration_t config = K4A_DEVICE_CONFIG_INIT_DISABLE_ALL;
config.fps_mode_id = K4A_FRAMES_PER_SECOND_30;
config.depth_mode_id = K4A_DEPTH_MODE_WFOV_2X2BINNED;
config.fps_mode_id = 2; // K4A_FRAMES_PER_SECOND_30
config.depth_mode_id = 3; // K4A_DEPTH_MODE_WFOV_2X2BINNED
config.color_format = K4A_IMAGE_FORMAT_COLOR_BGRA32;
config.color_mode_id = K4A_COLOR_RESOLUTION_720P;
config.color_mode_id = 1; // K4A_COLOR_RESOLUTION_720P

// This means that we'll only get captures that have both color and
// depth images, so we don't need to check if the capture contains
Expand All @@ -57,8 +57,8 @@ int main()

// Textures we can give to OpenGL / the viewer window to render.
//
Texture depthTexture = window.CreateTexture(GetDepthDimensions((k4a_depth_mode_t)config.depth_mode_id));
Texture colorTexture = window.CreateTexture(GetColorDimensions((k4a_color_resolution_t)config.color_mode_id));
Texture depthTexture = window.CreateTexture(GetDepthDimensions(config.depth_mode_id));
Texture colorTexture = window.CreateTexture(GetColorDimensions(config.color_mode_id));

// A buffer containing a BGRA color representation of the depth image.
// This is what we'll end up giving to depthTexture as an image source.
Expand Down Expand Up @@ -97,7 +97,7 @@ int main()
//
ColorizeDepthImage(depthImage,
K4ADepthPixelColorizer::ColorizeBlueToRed,
GetDepthModeRange((k4a_depth_mode_t)config.depth_mode_id),
GetDepthModeRange(config.depth_mode_id),
&depthTextureBuffer);
depthTexture.Update(&depthTextureBuffer[0]);

Expand Down
11 changes: 4 additions & 7 deletions include/k4a/k4atypes.h
Original file line number Diff line number Diff line change
Expand Up @@ -906,7 +906,7 @@ typedef struct _k4a_fps_mode_info_t
int fps;
} k4a_fps_mode_info_t;

// TODO: clean up old code that is temp commented out in this struct
// TODO: redo comments for color, depth and fps?
/** Configuration parameters for an Azure Kinect device.
*
* \remarks
Expand All @@ -927,15 +927,12 @@ typedef struct _k4a_device_configuration_t
k4a_image_format_t color_format;

/** Image resolution to capture with the color camera. */
// k4a_color_resolution_t color_resolution;
uint32_t color_mode_id;

/** Capture mode for the depth camera. */
// k4a_depth_mode_t depth_mode;
uint32_t depth_mode_id;

/** Desired frame rate for the color and depth camera. */
//k4a_fps_t camera_fps;
uint32_t fps_mode_id;

/** Only produce k4a_capture_t objects if they contain synchronized color and depth images.
Expand Down Expand Up @@ -1266,9 +1263,9 @@ typedef struct _k4a_imu_sample_t
* \endxmlonly
*/
static const k4a_device_configuration_t K4A_DEVICE_CONFIG_INIT_DISABLE_ALL = { K4A_IMAGE_FORMAT_COLOR_MJPG,
0,
0,
2,
0, // K4A_COLOR_RESOLUTION_OFF
0, // K4A_DEPTH_MODE_OFF
2, // K4A_FRAMES_PER_SECOND_30
false,
0,
K4A_WIRED_SYNC_MODE_STANDALONE,
Expand Down
7 changes: 4 additions & 3 deletions include/k4arecord/types.h
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ typedef enum
* @{
*/

// TODO: redo comments for color, depth and fps?
/** Structure containing the device configuration used to record.
*
* \see k4a_device_configuration_t
Expand All @@ -171,13 +172,13 @@ typedef struct _k4a_record_configuration_t
k4a_image_format_t color_format;

/** Image resolution used to record the color camera. */
k4a_color_resolution_t color_resolution;
uint32_t color_mode_id;

/** Mode used to record the depth camera. */
k4a_depth_mode_t depth_mode;
uint32_t depth_mode_id;

/** Frame rate used to record the color and depth camera. */
k4a_fps_t camera_fps;
uint32_t fps_mode_id;

/** True if the recording contains Color camera frames. */
bool color_track_enabled;
Expand Down