Mamckee/gcm leak #116
Merged
Mamckee/gcm leak #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel-lee-msft
approved these changes
May 7, 2025
mamckee
added a commit
that referenced
this pull request
May 21, 2025
mamckee
added a commit
that referenced
this pull request
May 22, 2025
* Mamckee/gcm leak (#116) * Add free back to GCM IV set * Update minor version * Update version for merge * Update version to 1.10.0-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #112 fixed an issue where the GCM IV was incorrectly cleared if the IV length was set to the current IV length, and the IV was already set. This was because
scossl_aes_gcm_set_iv_lenunconditionally cleared the IV. In fixing this I missed a section where the IV should be freed outside the function. I have checked everywhere elsescossl_aes_ccm_set_iv_lenis called and confirmed this was the only spot missing a free.Fixes #115