Skip to content

Mamckee/gcm leak #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mamckee merged 2 commits into from
May 7, 2025
Merged

Mamckee/gcm leak #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ab9e16
Add free back to GCM IV set
mamckee May 7, 2025
4dcc59d
Update minor version
mamckee May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
cmake_minimum_required(VERSION 3.13.0)

project(SymCrypt-OpenSSL
VERSION 1.8.0
VERSION 1.8.1
DESCRIPTION "The SymCrypt engine and provider for OpenSSL (SCOSSL)"
HOMEPAGE_URL "https://github.com/microsoft/SymCrypt-OpenSSL")

Expand Down
10 changes: 7 additions & 3 deletions ScosslCommon/src/scossl_aes_aead.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,17 @@ SCOSSL_STATUS scossl_aes_gcm_init_key(SCOSSL_CIPHER_GCM_CTX *ctx,
ctx->operationInProgress = 0;
if (iv != NULL)
{
if (!scossl_aes_gcm_set_iv_len(ctx, ivlen) ||
(ctx->iv = OPENSSL_memdup(iv, ctx->ivlen)) == NULL)
if (!scossl_aes_gcm_set_iv_len(ctx, ivlen))
{
return SCOSSL_FAILURE;
}

ctx->ivlen = ivlen;
OPENSSL_free(ctx->iv);

if ((ctx->iv = OPENSSL_memdup(iv, ctx->ivlen)) == NULL)
{
return SCOSSL_FAILURE;
}
}
if (key != NULL)
{
Expand Down