Skip to content

[MacOS]: fix wrong linking of Apple Frameworks #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2020
Merged

[MacOS]: fix wrong linking of Apple Frameworks #1523

merged 1 commit into from
Nov 3, 2020

Conversation

@Milerius
Copy link
Contributor

@Milerius Milerius commented Oct 26, 2020 •
edited
Loading

see #1522

Step to test this pr:

  • OSX OS (Catalina is fine)
  • Download additional osx sdk: git clone https://github.com/phracker/MacOSX-SDKs $HOME/osx_sdk
  • Clone vcpkg
  • Test first from master:
mkdir build
cd build
cmake -DCMAKE_BUILD_TYPE=Release \
            -DCMAKE_OSX_SYSROOT=$HOME/osx_sdk/MacOSX10.13.sdk \
            -DCMAKE_OSX_DEPLOYMENT_TARGET=10.13 \
             -DCMAKE_INSTALL_PREFIX=test_install ../
make cpprest -j8 install
cd test_install && grep -Hrn "SDK" .
  • merge this pr and repeat the test above ^

@Milerius
Copy link
Contributor Author

Milerius commented Oct 26, 2020 •
edited
Loading

It's fixed !

Before:

Capture d’écran 2020-10-26 à 13 49 43

After:

Capture d’écran 2020-10-26 à 13 48 53

@barcharcraz barcharcraz merged commit cfc6efe into microsoft:master Nov 3, 2020
@Milerius Milerius mentioned this pull request Dec 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ras0219 ras0219 ras0219 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Milerius @ras0219 @barcharcraz