Skip to content

[MacOS]: fix wrong linking of Apple Frameworks #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2020
Merged

[MacOS]: fix wrong linking of Apple Frameworks #1523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[MacOS]: fix wrong linking of Apple Frameworks 
see #1522
  • Loading branch information
@Milerius
Milerius authored Oct 26, 2020
commit dbb55638b2d7ecf248eb35db6148747a0f762677
2 changes: 1 addition & 1 deletion Release/src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ endif()
if(CPPREST_PPLX_IMPL STREQUAL "apple")
find_library(COREFOUNDATION CoreFoundation "/")
find_library(SECURITY Security "/")
target_link_libraries(cpprest PUBLIC ${COREFOUNDATION} ${SECURITY})
target_link_libraries(cpprest PRIVATE ${COREFOUNDATION} ${SECURITY})
target_sources(cpprest PRIVATE pplx/pplxapple.cpp pplx/pplx.cpp pplx/threadpool.cpp ../include/pplx/threadpool.h)
if(CPPREST_INSTALL_HEADERS)
install(FILES ../include/pplx/threadpool.h DESTINATION include/pplx)
Expand Down