Process review comments

spelling.dic

@@ -1,33 +1,39 @@
+
 # ***************************
 # List of misspelled words
 # Please, sort the list alphabetically
 # ***************************
-
 ansi
 appsettings
 blazor
 brotli
+columnheader
 combobox
 cref
 csproj
 currentcolor
+currentcolor
+datagrid
 datalist
+demopanel
+dialogtoggle
 elementreference
 evenodd
+eventargs
 gzip
 henkan
 heure
 heures
 inputfile
 javascript
 jours
+keycapture
 keydown
 keyup
 maintenant
 menuchecked
 menuclicked
 menuitem
-menuitem
 menuitemcheckbox
 menuitemcheckboxobsolete
 menuitemradio
@@ -39,56 +45,24 @@ muhenkan
 myid
 noattribute
 nonfile
+onaccordionchange
 onchange
 ondialogbeforetoggle
-ondialogtoggle
 ondropdownchange
 onmenuitemchange
 ontabchange
-ondropdownchange
-ondialogtoggle
-ondialogbeforetoggle
-myid
-menuclicked
-menuchecked
-onaccordionchange
-demopanel
-dialogtoggle
+rendertree
 rightclick
+rowheader
 rrggbb
 secondes
+sortabillity
 sourcecode
+Subscribable
 summarydata
 tabindex
 tablist
 tabpanel
-textarea
-sourcecode
-summarydata
-currentcolor
-menuitem
-menuitems
-rightclick
-menuitemcheckbox
-menuitem
-menuitemradio
-menuitemcheckboxobsolete
-menuitemradioobsolete
-onmenuitemchange
-ontabchange
-ondropdownchange
-ondialogtoggle
-ondialogbeforetoggle
-myid
-menuclicked
-menuchecked
-rendertree
 testid
-columnheader
-rowheader
-datagrid
-keycapture
+textarea
 wdelta
-sortabillity
-Subscribable
-eventargs

src/Core/Components/Pagination/FluentPaginator.razor

@@ -1,6 +1,6 @@
 @namespace Microsoft.FluentUI.AspNetCore.Components
 @inherits FluentComponentBase
-<div class="paginator" style="@Style">
+<div class="fluent-paginator" style="@Style">
     @if (State.TotalItemCount.HasValue)
     {
         <div class="summary">
@@ -14,12 +14,16 @@
             }
         </div>
         <nav role="navigation" class="paginator-nav">
-            <FluentButton @onclick="GoFirstAsync" Disabled="@(!CanGoBack || Disabled)" title="Go to first page" aria-label="Go to first page">
-                <FluentIcon Value="@(new CoreIcons.Regular.Size20.ChevronDoubleLeft())" Width="20px" />
-            </FluentButton>
-            <FluentButton @onclick="GoPreviousAsync" Disabled="@(!CanGoBack || Disabled)" title="Go to previous page" aria-label="Go to previous page">
-                <FluentIcon Value="@(new CoreIcons.Regular.Size24.ChevronLeft())" Width="20px" />
-            </FluentButton>
+            <FluentButton OnClick="GoFirstAsync"
+                          Disabled="@(!CanGoBack || Disabled)"
+                          Title="Go to first page"
+                          aria-label="Go to first page"
+                          IconStart="@(new CoreIcons.Regular.Size20.ChevronDoubleLeft())" />
+            <FluentButton OnClick="GoPreviousAsync"
+                          Disabled="@(!CanGoBack || Disabled)"
+                          Title="Go to previous page"
+                          aria-label="Go to previous page"
+                          IconStart="@(new CoreIcons.Regular.Size24.ChevronLeft())" />
             <div class="pagination-text">
                 @if (PaginationTextTemplate is not null)
                 {
@@ -31,12 +35,16 @@
                 }
 
             </div>
-            <FluentButton @onclick="GoNextAsync" Disabled="@(!CanGoForwards || Disabled)" title="Go to next page" aria-label="Go to next page">
-                <FluentIcon Value="@(new CoreIcons.Regular.Size24.ChevronRight())" Width="20px" />
-            </FluentButton>
-            <FluentButton @onclick="GoLastAsync" Disabled="@(!CanGoForwards || Disabled)" title="Go to last page" aria-label="Go to last page">
-                <FluentIcon Value="@(new CoreIcons.Regular.Size20.ChevronDoubleRight())" Width="20px" />
-            </FluentButton>
+            <FluentButton OnClick="GoNextAsync"
+                          Disabled="@(!CanGoForwards || Disabled)"
+                          Title="Go to next page"
+                          aria-label="Go to next page"
+                          IconStart="@(new CoreIcons.Regular.Size24.ChevronRight())" />
+            <FluentButton Onclick="GoLastAsync"
+                          Disabled="@(!CanGoForwards || Disabled)"
+                          Title="Go to last page"
+                          aria-label="Go to last page"
+                          IconStart="@(new CoreIcons.Regular.Size20.ChevronDoubleRight())" />
         </nav>
     }
 </div>

src/Core/Components/Pagination/FluentPaginator.razor.cs

@@ -18,11 +18,11 @@ public partial class FluentPaginator : FluentComponentBase, IDisposable
     /// <summary>
     /// Constructs an instance of <see cref="FluentPaginator" />.
     /// </summary>
-    public FluentPaginator()
+    public FluentPaginator(LibraryConfiguration configuration) : base(configuration)
     {
         // The "total item count" handler doesn't need to do anything except cause this component to re-render
-        _totalItemCountChanged = new(new EventCallback<PaginationState>(this, null));
-        _currentPageItemsChanged = new(new EventCallback<PaginationState>(this, null));
+        _totalItemCountChanged = new(new EventCallback<PaginationState>(this, @delegate: null));
+        _currentPageItemsChanged = new(new EventCallback<PaginationState>(this, @delegate: null));
     }
 
     /// <summary>

src/Core/Components/Pagination/FluentPaginator.razor.css

@@ -1,25 +1,28 @@
 .fluent-paginator {
-    display: flex;
-    /*border-top: 1px solid var(--neutral-stroke-divider-rest);*/
-    margin-top: 0.5rem;
-    padding: 0.25rem 0;
-    align-items: center;
-}
-
-.fluent-paginator .pagination-text {
-  margin: 0 0.5rem;
-}
-
-.fluent-paginator .paginator-nav {
-  padding: 0;
   display: flex;
-  margin-inline-start: auto;
-  margin-inline-end: 0;
-  gap: 0.5rem;
+  /*border-top: 1px solid var(--neutral-stroke-divider-rest);*/
+  margin-top: 0.5rem;
+  padding: 0.25rem 0;
   align-items: center;
 }
 
-
+  .fluent-paginator .summary {
+  }
+
+  .fluent-paginator .pagination-text {
+    margin: 0 0.5rem;
+  }
+
+  .fluent-paginator .paginator-nav {
+    padding: 0;
+    display: flex;
+    margin-inline-start: auto;
+    margin-inline-end: 0;
+    gap: 0.5rem;
+    align-items: center;
+  }
+
+
 [dir="rtl"] .fluent-paginator fluent-button > svg {
-    transform: rotate(180deg);
+  transform: rotate(180deg);
 }

src/Core/Components/Pagination/PaginationState.cs

@@ -6,6 +6,8 @@
 
 namespace Microsoft.FluentUI.AspNetCore.Components;
 
+// ToDo: remove pragma after next PR
+#pragma warning disable CS1574 // XML comment has cref attribute that could not be resolved
 /// <summary>
 /// Holds state to represent pagination in a <see cref="FluentDataGrid{TGridItem}"/>.
 /// </summary>
@@ -70,8 +72,9 @@ public async Task SetItemsPerPageAsync(int itemsPerPage)
         await CurrentPageItemsChanged.InvokeCallbacksAsync(this);
         if (TotalItemCount.HasValue)
         {
-            await SetTotalItemCountAsync(TotalItemCount.Value, true);
+            await SetTotalItemCountAsync(TotalItemCount.Value, force: true);
         }
+
         return;
     }
 
@@ -81,11 +84,11 @@ public async Task SetItemsPerPageAsync(int itemsPerPage)
     /// <param name="totalItemCount">The total number of items</param>
     /// <param name="force">If true, the total item count will be updated even if it is the same as the current value.</param>
     /// <returns></returns>
-    public Task SetTotalItemCountAsync(int totalItemCount, bool force = false)
+    public async Task SetTotalItemCountAsync(int totalItemCount, bool force = false)
     {
         if (totalItemCount == TotalItemCount && !force)
         {
-            return Task.CompletedTask;
+            return;
         }
 
         TotalItemCount = totalItemCount;
@@ -94,11 +97,12 @@ public Task SetTotalItemCountAsync(int totalItemCount, bool force = false)
         {
             // If the number of items has reduced such that the current page index is no longer valid, move
             // automatically to the final valid page index and trigger a further data load.
-            _ = SetCurrentPageIndexAsync(LastPageIndex.Value);
+            await SetCurrentPageIndexAsync(LastPageIndex.Value);
         }
 
         // Under normal circumstances, we just want any associated pagination UI to update
         TotalItemCountChanged?.Invoke(this, new TotalItemCountChangedEventArgs(TotalItemCount));
-        return TotalItemCountChangedSubscribable.InvokeCallbacksAsync(this);
+        await TotalItemCountChangedSubscribable.InvokeCallbacksAsync(this);
     }
 }
+#pragma warning restore CS1574 // XML comment has cref attribute that could not be resolved

src/Core/Enums/DataGridCellType.cs

@@ -6,6 +6,9 @@
 
 namespace Microsoft.FluentUI.AspNetCore.Components;
 
+// ToDo: remove pragma after next PR
+#pragma warning disable CS1574 // XML comment has cref attribute that could not be resolved
+
 /// <summary>
 /// The type of <see cref="FluentDataGridCell{TGridItem}"/> in a <see cref="FluentDataGrid{TGridItem}"/>.
 /// </summary>
@@ -28,3 +31,5 @@ public enum DataGridCellType
     [Description("rowheader")]
     RowHeader,
 }
+#pragma warning restore CS1574 // XML comment has cref attribute that could not be resolved
+

src/Core/Enums/DataGridDisplayMode.cs

@@ -4,6 +4,8 @@
 
 namespace Microsoft.FluentUI.AspNetCore.Components;
 
+// ToDo: remove pragma after next PR
+#pragma warning disable CS1574 // XML comment has cref attribute that could not be resolved
 /// <summary>
 /// The type of rendering to use for the <see cref="FluentDataGrid{TGridItem}"/>
 /// </summary>
@@ -20,5 +22,6 @@ public enum DataGridDisplayMode
     /// With this mode fr units cannot be used to set the column widths.
     /// </summary>
     Table,
-
 }
+#pragma warning restore CS1574 // XML comment has cref attribute that could not be resolved
+

src/Core/Enums/DataGridGeneratedHeaderType.cs

@@ -4,6 +4,8 @@
 
 namespace Microsoft.FluentUI.AspNetCore.Components;
 
+// ToDo: remove pragma after next PR
+#pragma warning disable CS1574 // XML comment has cref attribute that could not be resolved
 /// <summary>
 /// The option for generating a header for the <see cref="FluentDataGrid{TGridItem}" />.
 /// </summary>
@@ -22,5 +24,6 @@ public enum DataGridGeneratedHeaderType
     /// <summary>
     /// Generate a sticky header row.
     /// </summary>
-    Sticky
+    Sticky,
 }
+#pragma warning restore CS1574 // XML comment has cref attribute that could not be resolved

src/Core/Enums/DataGridResizeType.cs

@@ -4,6 +4,8 @@
 
 namespace Microsoft.FluentUI.AspNetCore.Components;
 
+// ToDo: remove pragma after next PR
+#pragma warning disable CS1574 // XML comment has cref attribute that could not be resolved
 /// <summary>
 /// The type of <see cref="FluentDataGridRow{TGridItem}"/> in a <see cref="FluentDataGrid{TGridItem}"/>.
 /// </summary>
@@ -19,3 +21,4 @@ public enum DataGridResizeType
     /// </summary>
     Exact,
 }
+#pragma warning restore CS1574 // XML comment has cref attribute that could not be resolved

src/Core/Enums/DataGridRowSize.cs

@@ -4,6 +4,8 @@
 
 namespace Microsoft.FluentUI.AspNetCore.Components;
 
+// ToDo: remove pragma after next PR
+#pragma warning disable CS1574 // XML comment has cref attribute that could not be resolved
 /// <summary>
 /// The height of each <see cref="FluentDataGridRow{TGridItem}"/> in a <see cref="FluentDataGrid{TGridItem}"/>.
 /// Values are in pixels.
@@ -30,3 +32,4 @@ public enum DataGridRowSize
     /// </summary>
     Large = 58,
 }
+#pragma warning restore CS1574 // XML comment has cref attribute that could not be resolved

src/Core/Enums/DataGridRowType.cs

@@ -6,6 +6,8 @@
 
 namespace Microsoft.FluentUI.AspNetCore.Components;
 
+// ToDo: remove pragma after next PR
+#pragma warning disable CS1574 // XML comment has cref attribute that could not be resolved
 /// <summary>
 /// The type of <see cref="FluentDataGridRow{TGridItem}"/> in a <see cref="FluentDataGrid{TGridItem}"/>.
 /// </summary>
@@ -27,3 +29,4 @@ public enum DataGridRowType
     [Description("sticky-header")]
     StickyHeader,
 }
+#pragma warning restore CS1574 // XML comment has cref attribute that could not be resolved

src/Core/Enums/DataGridSelectMode.cs

@@ -4,6 +4,8 @@
 
 namespace Microsoft.FluentUI.AspNetCore.Components;
 
+// ToDo: remove pragma after next PR
+#pragma warning disable CS1574 // XML comment has cref attribute that could not be resolved
 /// <summary>
 /// How rows can be selected in a <see cref="FluentDataGrid{TGridItem}"/> when using a <see cref="SelectColumn{TGridItem}"/>.
 /// </summary>
@@ -24,3 +26,4 @@ public enum DataGridSelectMode
     /// </summary>
     Multiple,
 }
+#pragma warning restore CS1574 // XML comment has cref attribute that could not be resolved

src/Core/Enums/DataGridSortDirection.cs

@@ -4,6 +4,8 @@
 
 namespace Microsoft.FluentUI.AspNetCore.Components;
 
+// ToDo: remove pragma after next PR
+#pragma warning disable CS1574 // XML comment has cref attribute that could not be resolved
 /// <summary>
 /// Describes the direction in which a <see cref="FluentDataGrid{TGridItem}"/> column is sorted.
 /// </summary>
@@ -26,3 +28,4 @@ public enum DataGridSortDirection
     /// </summary>
     Descending,
 }
+#pragma warning restore CS1574 // XML comment has cref attribute that could not be resolved