Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
93f6cf9
- Add enums
vnbaaij Jun 12, 2025
b255f69
- Add DataGrid component
vnbaaij Jun 12, 2025
96e40df
Add DataGridGeneratedHeaderType
vnbaaij Jun 12, 2025
f6d0fb1
Merge branch 'users/vnbaaij/dev-v5/datagrid-part1' into users/vnbaaij…
vnbaaij Jun 12, 2025
1059dbe
Merge branch 'dev-v5' into users/vnbaaij/dev-v5/datagrid-part1
dvoituron Jun 12, 2025
595ff78
Fix analyzer errors
vnbaaij Jun 12, 2025
b1cf680
- Add Typical demo and flags
vnbaaij Jun 12, 2025
8393e35
Work on review comments
vnbaaij Jun 12, 2025
8cd48c6
Merge branch 'users/vnbaaij/dev-v5/datagrid-part1' of https://github.…
vnbaaij Jun 12, 2025
202c10a
Process review comments
vnbaaij Jun 12, 2025
5aa2c65
Add language resources
vnbaaij Jun 12, 2025
777e854
Add Unit Tests for Paginator
vnbaaij Jun 12, 2025
448c89e
More review comments
vnbaaij Jun 13, 2025
3146aeb
Update tests. Now 100% lc
vnbaaij Jun 13, 2025
69ffae6
- Add Typical demo and flags
vnbaaij Jun 13, 2025
35e0334
Replace tokens (WIP)
vnbaaij Jun 13, 2025
b92c83c
Remove flags. These will be added to sample data project in separate PR
vnbaaij Jun 17, 2025
430abd5
Remove DI abstractions package. Not needed
vnbaaij Jun 17, 2025
d0c1052
Merge dev-v5
vnbaaij Jun 17, 2025
33af462
Add IsFixed parameter
vnbaaij Jun 17, 2025
689fe43
merge dev-v5
vnbaaij Jun 17, 2025
44f7d0d
MAke example grid mor functional and look better
vnbaaij Jun 17, 2025
6fc0809
Add initial tests. They are not passing yet
vnbaaij Jun 18, 2025
5bcb9fa
Add surpression atribute, fix other analyzer warnings
vnbaaij Jun 18, 2025
a30dabf
Use localized strings
vnbaaij Jun 18, 2025
aadf080
Merg dev-v5
vnbaaij Jun 18, 2025
70c342b
Fix tests
vnbaaij Jun 18, 2025
b826128
Add Tests
vnbaaij Jun 19, 2025
d0979ea
Add tests for PaginatinState and TotalItemCountChangedEventArgs
vnbaaij Jun 19, 2025
a6aa6fc
Merge branch 'users/vnbaaij/dev-v5/pagination-tests' into users/vnbaa…
vnbaaij Jun 19, 2025
613cbd0
Merge branch 'dev-v5' into users/vnbaaij/dev-v5/pagination-tests
vnbaaij Jun 19, 2025
af4f1e8
Add Row tests
vnbaaij Jun 19, 2025
89038a7
process review comments
vnbaaij Jun 19, 2025
bcdffd9
Merge branch 'users/vnbaaij/dev-v5/pagination-tests' into users/vnbaa…
vnbaaij Jun 19, 2025
ba9c0fb
More tests
vnbaaij Jun 19, 2025
924df75
More tests
vnbaaij Jun 19, 2025
726cf24
Merge branch 'users/vnbaaij/dev-v5/datagrid-part2' of https://github.…
vnbaaij Jun 20, 2025
8fe02c0
- Add typical demo
vnbaaij Jun 23, 2025
abb696c
More tests
vnbaaij Jun 29, 2025
4aae12f
- More tests
vnbaaij Jun 29, 2025
39dc140
Merge branch 'dev-v5' into users/vnbaaij/dev-v5/datagrid-part2
vnbaaij Jul 1, 2025
f4b691a
Update file headers
vnbaaij Jul 1, 2025
1f50f07
Convert DataGrid JS to TS
vnbaaij Jul 1, 2025
097db2f
Implement fix for #3963
vnbaaij Jul 1, 2025
713d96b
Bring in changes made in v4 with #3949
vnbaaij Jul 1, 2025
2698837
- Update file headers
vnbaaij Jul 1, 2025
460a82f
Merge branch 'users/vnbaaij/dev-v5/datagrid-part2' into users/vnbaaij…
vnbaaij Jul 1, 2025
f9ce111
Merge branch 'dev-v5' into users/vnbaaij/dev-v5/datagrid-part3
vnbaaij Jul 2, 2025
ab02f1c
Merge branch 'dev-v5' into users/vnbaaij/dev-v5/datagrid-part2
vnbaaij Jul 2, 2025
088dd55
Process review comments:
vnbaaij Jul 2, 2025
ede49e6
Forgot to change the docs
vnbaaij Jul 2, 2025
87cb81a
Merge branch 'users/vnbaaij/dev-v5/datagrid-part2' into users/vnbaaij…
vnbaaij Jul 2, 2025
d47fc5e
Merge branch 'dev-v5' into users/vnbaaij/dev-v5/datagrid-part2
vnbaaij Jul 2, 2025
f921191
- Use auto-generated constant
vnbaaij Jul 2, 2025
25e046e
Merge branch 'users/vnbaaij/dev-v5/datagrid-part2' of https://github.…
vnbaaij Jul 2, 2025
e6ec4a3
DataGrid docs and examples
vnbaaij Jul 2, 2025
07365bd
Merge branch 'users/vnbaaij/dev-v5/datagrid-part3' into users/vnbaaij…
vnbaaij Jul 2, 2025
5af4579
Merge branch 'dev-v5' into users/vnbaaij/dev-v5/datagrid-part4
vnbaaij Jul 2, 2025
66af301
Merge branch 'users/vnbaaij/dev-v5/datagrid-part2' into users/vnbaaij…
vnbaaij Jul 3, 2025
9e89b82
Merge branch 'users/vnbaaij/dev-v5/datagrid-part3' into users/vnbaaij…
vnbaaij Jul 3, 2025
855fe34
Merge branch 'users/vnbaaij/dev-v5/datagrid-part4' of https://github.…
vnbaaij Jul 3, 2025
e3c942f
Process review comments
vnbaaij Jul 3, 2025
f6d458b
More review comments
vnbaaij Jul 3, 2025
64cf5bb
Merge branch 'dev-v5' into users/vnbaaij/dev-v5/datagrid-part2
vnbaaij Jul 3, 2025
85154bf
- Undo make internal GridItemsProvider*
vnbaaij Jul 3, 2025
ed02449
Update test verified files
vnbaaij Jul 3, 2025
770c533
merge part 2
vnbaaij Jul 3, 2025
c6a2f1b
Merge branch 'users/vnbaaij/dev-v5/datagrid-part3' into users/vnbaaij…
vnbaaij Jul 3, 2025
d0246dd
Merge dev-v5
vnbaaij Jul 3, 2025
36dc27b
- Fix when to show header menu
vnbaaij Jul 3, 2025
150c1fd
- Rename getting started
vnbaaij Jul 3, 2025
567729b
WIP
vnbaaij Jul 18, 2025
61deb6a
Update samples and structure
vnbaaij Jul 21, 2025
e1932a6
Make all DataGrid samples work
vnbaaij Jul 21, 2025
62753d4
Merge branch 'dev-v5' into users/vnbaaij/dev-v5/datagrid-part4
vnbaaij Jul 21, 2025
7c4f77b
Update DataGrid verified tests files
vnbaaij Jul 21, 2025
998b8c9
Merge branch 'users/vnbaaij/dev-v5/datagrid-part4' of https://github.…
vnbaaij Jul 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
  • Loading branch information
vnbaaij committed Jun 18, 2025
commit 70c342bf87602ebcf5cd35b362c90208da3d529f
Original file line number Diff line number Diff line change
@@ -0,0 +1,90 @@
<FluentStack VerticalAlignment="VerticalAlignment.Center">
<FluentSelect Items="@(Enum.GetValues<DataGridSelectMode>())"
@bind-SelectedOption="@Mode" />
<FluentCheckbox @bind-Value="@UseSelectedItems"
@bind-Value:after="@(() => ResetSelectItems())"
Label="Use `SelectedItems` property" />
<FluentCheckbox @bind-Value="@SelectFromEntireRow"
@bind-Value:after="@(() => ResetSelectItems())"
Label="Use `SelectFromEntireRow` property" />
<FluentCheckbox @bind-Value="@SelectableBefore2000"
@bind-Value:after="@(() => ResetSelectItems())"
Label="Use `Selectable` property" />
</FluentStack>

@if (UseSelectedItems)
{
@* Sample using SelectedItems *@
<div>Using SelectedItems</div>

<FluentDataGrid Items="@People" ShowHover="@SelectFromEntireRow" TGridItem="Person">
<SelectColumn TGridItem="Person"
SelectMode="@Mode"
SelectFromEntireRow="@SelectFromEntireRow"
Selectable="@(e => !SelectableBefore2000 || e.BirthDate.Year >= 2000)"
@bind-SelectedItems="@SelectedItems" />
<PropertyColumn Width="100px" Property="@(p => p.PersonId)" Title="ID" />
<PropertyColumn Width="300px" Property="@(p => p.Name)" />
<PropertyColumn Width="150px" Property="@(p => p.BirthDate)" Format="yyyy-MM-dd" Sortable="true" />
</FluentDataGrid>

<div style="margin-top: 0.5rem;">
<b>SelectedItems:</b>
@String.Join("; ", SelectedItems.Select(p => p.Name))
</div>
}
else
{
@* Sample using Property and OnSelect *@
<div>Using Property and OnSelect</div>

<FluentDataGrid Items="@People" ShowHover="@SelectFromEntireRow" TGridItem="Person">
<SelectColumn TGridItem="Person"
SelectMode="@Mode"
SelectFromEntireRow="@SelectFromEntireRow"
Selectable="@(e => !SelectableBefore2000 || e.BirthDate.Year >= 2000)"
Property="@(e => e.Selected)"
OnSelect="@(e => e.Item.Selected = e.Selected)"
SelectAll="@(People.All(p => p.Selected))"
SelectAllChanged="@(all => People.ToList().ForEach(p => p.Selected = (all == true)))" />
<PropertyColumn Width="100px" Property="@(p => p.PersonId)" Title="ID" />
<PropertyColumn Width="300px" Property="@(p => p.Name)" />
<PropertyColumn Width="150px" Property="@(p => p.BirthDate)" Format="yyyy-MM-dd" Sortable="true" />
</FluentDataGrid>

<div>
<b>Peoples:</b>
@String.Join("; ", People.Where(p => p.Selected).Select(p => p.Name))
</div>
}

@code {
bool UseSelectedItems = true;
bool SelectFromEntireRow = true;
bool SelectableBefore2000 = false;
DataGridSelectMode Mode = DataGridSelectMode.Single;

IEnumerable<Person> SelectedItems = People.Where(p => p.Selected);

record Person(int PersonId, string Name, DateOnly BirthDate)
{
public bool Selected { get; set; }
};

static IQueryable<Person> People = new[]
{
new Person(10895, "Jean Martin", new DateOnly(1985, 3, 16)) { Selected = true },
new Person(10944, "António Langa", new DateOnly(1991, 12, 1)),
new Person(11203, "Julie Smith", new DateOnly(1958, 10, 10)),
new Person(11205, "Nur Sari", new DateOnly(1922, 4, 27)),
new Person(11898, "Jose Hernandez", new DateOnly(2011, 5, 3)),
new Person(12130, "Kenji Sato", new DateOnly(2004, 1, 9)),
}.AsQueryable();

private void ResetSelectItems()
{
People.ToList().ForEach(i => i.Selected = false);
People.First().Selected = true;
SelectedItems = People.Where(p => p.Selected);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,5 @@ The resize options UI is using a customized string for the label ('Width (+/- 10
the custom localizer which is registered in the Server project's `Program.cs` file.

{{ DataGridTypical }}

{{ DataGridMultiSelect }}
54 changes: 39 additions & 15 deletions src/Core/Components/DataGrid/Columns/SelectColumn.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ public class SelectColumn<TGridItem> : ColumnBase<TGridItem>
private readonly Icon IconUnselectedSingle = new CoreIcons.Regular.Size20.RadioButton().WithColor(Color.Lightweight);
private readonly Icon IconSelectedSingle = new CoreIcons.Filled.Size20.RadioButton();

private readonly List<TGridItem> _selectedItems = [];

/// <summary>
/// Initializes a new instance of <see cref="SelectColumn{TGridItem}"/>.
/// </summary>
Expand Down Expand Up @@ -64,13 +66,13 @@ public SelectColumn()
/// Gets or sets the list of selected items.
/// </summary>
[Parameter]
public IList<TGridItem> SelectedItems { get; set; } = [];
public IEnumerable<TGridItem> SelectedItems { get; set; } = [];

/// <summary>
/// Gets or sets a callback when list of selected items changed.
/// </summary>
[Parameter]
public EventCallback<IList<TGridItem>> SelectedItemsChanged { get; set; }
public EventCallback<IEnumerable<TGridItem>> SelectedItemsChanged { get; set; }

/// <summary>
/// Gets or sets the selection mode (Single, SingleSticky or Multiple).
Expand Down Expand Up @@ -175,7 +177,9 @@ public SelectColumn()
/// </summary>
public void ClearSelection()
{
SelectedItems?.Clear();
_selectedItems.Clear();
SelectedItems = _selectedItems;

RefreshHeaderContent();
}

Expand Down Expand Up @@ -254,6 +258,18 @@ protected internal override Task OnCellKeyDownAsync(FluentDataGridCell<TGridItem
return Task.CompletedTask;
}

//private void UpdateSelectedItems(IEnumerable<TGridItem> value)
//{
// if (_selectedItems != value)
// {
// _selectedItems.Clear();
// _selectedItems.AddRange(value);
// SelectAll = false;

// SelectedItems = _selectedItems;
// }
//}

/// <summary />
private async Task AddOrRemoveSelectedItemAsync(TGridItem? item)
{
Expand All @@ -264,7 +280,7 @@ private async Task AddOrRemoveSelectedItemAsync(TGridItem? item)
return;
}

if (SelectedItems.Remove(item))
if (_selectedItems.Remove(item))
{
SelectAll = false;
await CallOnSelectAsync(item, isSelected: false);
Expand All @@ -278,13 +294,14 @@ private async Task AddOrRemoveSelectedItemAsync(TGridItem? item)
await CallOnSelectAsync(previous, isSelected: false);
}

SelectedItems.Clear();
_selectedItems.Clear();
}

SelectedItems.Add(item);
_selectedItems.Add(item);
await CallOnSelectAsync(item, isSelected: true);
}

SelectedItems = _selectedItems;
if (SelectedItemsChanged.HasDelegate)
{
await SelectedItemsChanged.InvokeAsync(SelectedItems);
Expand Down Expand Up @@ -363,14 +380,20 @@ private RenderFragment<TGridItem> GetDefaultChildContent()
var selected = SelectedItems.Contains(item) || Property.Invoke(item);

// Sync with SelectedItems list
if (selected && !SelectedItems.Contains(item))
if (selected && !_selectedItems.Contains(item))
{
SelectedItems.Add(item);
_selectedItems.Add(item);
RefreshHeaderContent();
}
else if (!selected && SelectedItems.Contains(item))
else if (!selected && _selectedItems.Contains(item))
{
_selectedItems.Remove(item);
}

SelectedItems = _selectedItems;
if (SelectedItemsChanged.HasDelegate)
{
SelectedItems.Remove(item);
_ = SelectedItemsChanged.InvokeAsync(SelectedItems);
}

builder.OpenComponent<FluentIcon<Icon>>(0);
Expand Down Expand Up @@ -462,7 +485,7 @@ private void RefreshHeaderContent()
return false;
}

if (SelectedItems.Count == InternalGridContext.TotalItemCount || SelectAll == true)
if (SelectedItems.Take(InternalGridContext.TotalItemCount + 1).Count() == InternalGridContext.TotalItemCount || SelectAll == true)
{
return true;
}
Expand Down Expand Up @@ -501,20 +524,21 @@ internal async Task OnClickAllAsync(MouseEventArgs e)
await SelectAllChanged.InvokeAsync(SelectAll);
}

var count = SelectedItems.Count;
var count = SelectedItems.Count();
// SelectedItems
SelectedItems.Clear();
_selectedItems.Clear();
if (SelectAll == true && count != InternalGridContext.TotalItemCount)
{
// Only add selectable items
_ = SelectedItems.Concat((InternalGridContext.Grid.Items?.ToList() ?? InternalGridContext.Items)
_selectedItems.AddRange((InternalGridContext.Grid.Items?.ToList() ?? InternalGridContext.Items)
.Where(item => Selectable?.Invoke(item) ?? true)
);
}

SelectedItems = _selectedItems;
if (SelectedItemsChanged.HasDelegate)
{
await SelectedItemsChanged.InvokeAsync(SelectedItems);
await SelectedItemsChanged.InvokeAsync(_selectedItems);
}

RefreshHeaderContent();
Expand Down
4 changes: 2 additions & 2 deletions src/Core/Components/DataGrid/FluentDataGrid.razor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -898,7 +898,7 @@ private string AriaSortValue(ColumnBase<TGridItem> column)
? (_sortByAscending ? "ascending" : "descending")
: "none";

private string? StyleValue => new StyleBuilder(Style)
private string? StyleValue => DefaultStyleBuilder
.AddStyle("grid-template-columns", _internalGridTemplateColumns, !string.IsNullOrWhiteSpace(_internalGridTemplateColumns) && DisplayMode == DataGridDisplayMode.Grid)
.AddStyle("grid-template-rows", "auto 1fr", (_internalGridContext.Items.Count == 0 || Items is null || EffectiveLoadingValue) && DisplayMode == DataGridDisplayMode.Grid)
.AddStyle("height", "100%", _internalGridContext.TotalItemCount == 0 || EffectiveLoadingValue)
Expand All @@ -918,7 +918,7 @@ private string AriaSortValue(ColumnBase<TGridItem> column)

private string? GridClass()
{
return new CssBuilder(Class)
return DefaultClassBuilder
.AddClass("fluent-data-grid")
.AddClass("grid", DisplayMode == DataGridDisplayMode.Grid)
.AddClass("auto-fit", AutoFit)
Expand Down
6 changes: 4 additions & 2 deletions src/Core/Components/DataGrid/FluentDataGridCell.razor
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@

@if (CellType == DataGridCellType.Default)
{
<td col-index=@GridColumn
<td id="@Id"
col-index=@GridColumn
class="@ClassValue"
style="@StyleValue"
role="gridcell"
Expand All @@ -18,7 +19,8 @@
}
else
{
<th col-index=@GridColumn
<th id="@Id"
col-index=@GridColumn
class="@ClassValue"
style="@StyleValue"
@oncontextmenu:preventDefault="true"
Expand Down
5 changes: 2 additions & 3 deletions src/Core/Components/DataGrid/FluentDataGridCell.razor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
using Microsoft.AspNetCore.Components;
using Microsoft.AspNetCore.Components.Web;
using Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure;
using Microsoft.FluentUI.AspNetCore.Components.Utilities;

namespace Microsoft.FluentUI.AspNetCore.Components;

Expand Down Expand Up @@ -70,15 +69,15 @@ public FluentDataGridCell(LibraryConfiguration configuration) : base(configurati
protected FluentDataGrid<TGridItem> Grid => InternalGridContext.Grid;

/// <summary />
protected string? ClassValue => new CssBuilder(Class)
protected string? ClassValue => DefaultClassBuilder
.AddClass("column-header", when: CellType == DataGridCellType.ColumnHeader)
.AddClass("select-all", when: CellType == DataGridCellType.ColumnHeader && Column is SelectColumn<TGridItem>)
.AddClass("multiline-text", when: Grid.MultiLine && (Grid.Items is not null || Grid.ItemsProvider is not null) && CellType != DataGridCellType.ColumnHeader)
.AddClass(Owner.Class)
.Build();

/// <summary />
protected string? StyleValue => new StyleBuilder(Style)
protected string? StyleValue => DefaultStyleBuilder
.AddStyle("grid-column", GridColumn.ToString(CultureInfo.InvariantCulture), () => !Grid.EffectiveLoadingValue && (Grid.Items is not null || Grid.ItemsProvider is not null) && Grid.DisplayMode == DataGridDisplayMode.Grid)
.AddStyle("text-align", "center", Column is SelectColumn<TGridItem>)
.AddStyle("align-content", "center", Column is SelectColumn<TGridItem>)
Expand Down
3 changes: 2 additions & 1 deletion src/Core/Components/DataGrid/FluentDataGridRow.razor
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
@typeparam TGridItem
@attribute [CascadingTypeParameter(nameof(TGridItem))]
<CascadingValue Value="this" Name="OwningRow">
<tr class="@ClassValue"
<tr id="@Id"
class="@ClassValue"
style="@StyleValue"
data-row-index=@RowIndex
role="row"
Expand Down
5 changes: 2 additions & 3 deletions src/Core/Components/DataGrid/FluentDataGridRow.razor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
using Microsoft.AspNetCore.Components;
using Microsoft.AspNetCore.Components.Web;
using Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure;
using Microsoft.FluentUI.AspNetCore.Components.Utilities;

namespace Microsoft.FluentUI.AspNetCore.Components;

Expand Down Expand Up @@ -84,13 +83,13 @@ public FluentDataGridRow(LibraryConfiguration configuration) : base(configuratio
protected FluentDataGrid<TGridItem> Grid => InternalGridContext.Grid;

/// <summary />
protected string? ClassValue => new CssBuilder(Class)
protected string? ClassValue => DefaultClassBuilder
.AddClass("fluent-data-grid-row")
.AddClass("hover", when: Grid.ShowHover)
.Build();

/// <summary />
protected string? StyleValue => new StyleBuilder(Style)
protected string? StyleValue => DefaultStyleBuilder
.Build();

/// <summary>
Expand Down
6 changes: 6 additions & 0 deletions tests/Core/Components/Base/ComponentBaseTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
using Bunit;
using Microsoft.AspNetCore.Components;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure;
using Microsoft.JSInterop;
using Xunit;

Expand Down Expand Up @@ -40,6 +41,11 @@ public class ComponentBaseTests : Bunit.TestContext
{ typeof(FluentHighlighter), Loader.Default.WithRequiredParameter("HighlightedText", "AB").WithRequiredParameter("Text", "ABCDEF")},
{ typeof(FluentKeyCode), Loader.Default.WithRequiredParameter("ChildContent", (RenderFragment)(builder => builder.AddContent(0, "MyContent"))) },
{ typeof(FluentPaginator), Loader.Default.WithRequiredParameter("State", new PaginationState()) },
{ typeof(FluentDataGrid<>), Loader.MakeGenericType(typeof(string)) },
{ typeof(FluentDataGridRow<>), Loader.MakeGenericType(typeof(string)).WithCascadingValue(new InternalGridContext<string>(new FluentDataGrid<string>(new LibraryConfiguration()))) },
{ typeof(FluentDataGridCell<>), Loader.MakeGenericType(typeof(string))
.WithCascadingValue(new InternalGridContext<string>(new FluentDataGrid<string>(new LibraryConfiguration())))
.WithCascadingValue("OwningRow", new FluentDataGridRow<string>(new LibraryConfiguration()) { InternalGridContext = new InternalGridContext<string>(new FluentDataGrid<string>(new LibraryConfiguration())) }) },
};

/// <summary />
Expand Down
Loading
Loading