[MIGraphX EP] Fix compilation after cherry-picking from win-onnxruntime #25516
Conversation
|
This is still failing unit tests on Linux side . Tried a build with main + this fix as part of some other integration and UTs are flagging this as a fail. There's a gap in CI here between Linux builds for some reason. 
|
|
Weird, running the test by hand I get this. 
Your CI is saying this passed but it doesn't look like you're building anything at all related to ROCm, is there something cached somewhere being invoked? 
|
|
I made the test available only for Windows. A similar test for TensorRT is also available only for Windows. |
|
Apparently CI has been removed for MIGraphX builds entirely? |
Doesn't change the fact that we don't have a pipeline for either OS so we don't cause mainline build breaks. |
Manual validation report with this fix |
|
Can we get an issue filed to track this not being covered in CI? Once the checks we do have pass and given the manual validation performed, I'm okay to approve on this but we need to get CI back up and running so we don't break this unknowingly again. |
@nieubank You need to discuss this with your internal security team and allocation of GPU, as well as ITARs. Thats explanation I got when asking on this PR from @snnn after seeing that CI was ripped here without a peep. Just get back to us when this is running. We have an almalinux image thats updated every ROCm release that we actively maintain that meets your requirements. Not sure why nobody reached out, or even bothered looking, it already seems like you pull Nvidia docker images from dockerhub so more unsure why nobody bothered to even look. https://hub.docker.com/r/rocm/dev-almalinux-8/tags We're stopping integration until you guys decide what you're doing on your end with security. Atleast I am from the Linux side with mainline broken. Too much risk in the middle of release. Our windows team and devs are happy to help you integrate and start changes for your needs, but I'm more surprised how this has been handled today. This is a large glaring security and program risk and we're flying blind in terms of coverage |
…me (microsoft#25516) After cherry-picking from win-onnxruntime (microsoft#25481), the MIGraphX EP stopped compiling on the main branch.
Cherry-pick MiGraphX EP fixes from upstream for rel-1.23.0 This PR cherry-picks three critical fixes for the MiGraphX Execution Provider: 1. Fix compilation after cherry-picking from win-onnxruntime (#25516) - Adds ORT_UNUSED_PARAMETER(num_devices) to fix unused parameter warning - Corrects struct usage in CreateIExecutionProvider method 2. Fix CreateExecutionProviderFactory with correct struct and change vendor_id (#25625) - Updates vendor_id from 0x1002 to 0x9999 to allow DML EP to be default - Ensures proper device ordering in provider_policy_context.cc 3. Update OrtEpFactory in MiGraphX EP (#25567) - Adds complete OrtEpFactory infrastructure for auto EP selection - Implements all required factory methods with noexcept specifiers - Sets ort_version_supported to ORT_API_VERSION - Enables MiGraphX/AMDGPU EP integration with hardware device detection These fixes ensure MiGraphX EP builds correctly and integrates properly with the ORT execution provider selection framework in the 1.23.0 release. Cherry-picked commits: - 87f1499 - 14ca6df - 131cf40 --------- Co-authored-by: Artur Wojcik <[email protected]> Co-authored-by: Owen Zhang <[email protected]> Co-authored-by: ozhang <[email protected]>
…me (microsoft#25516) After cherry-picking from win-onnxruntime (microsoft#25481), the MIGraphX EP stopped compiling on the main branch.
5 participants
After cherry-picking from win-onnxruntime (#25481), the MIGraphX EP stopped compiling on the main branch.