[QNN EP] fix memory leak in OrtEpFactory::GetSupportedDevices() #25968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianlizarraga
commented
Sep 5, 2025
jywu-msft
approved these changes
Sep 5, 2025
snnn
pushed a commit
to snnn/onnxruntime
that referenced
this pull request
Sep 8, 2025
…osoft#25968) ### Description Fixes memory leak in `OrtEpFactory::GetSupportedDevices()`. The `OrtKeyValuePairs` instance created by the factory was not released. This memory leak can be reproduced by running the unit test [QnnHTPBackendTests.AutoEp_PreferNpu](https://github.com/microsoft/onnxruntime/blob/4e2699fbf24d96d2a0261b30509864da08b701de/onnxruntime/test/providers/qnn/qnn_basic_test.cc#L1426). ### Motivation and Context Fix memory leak that one encounters when using automatic EP selection (e.g., PREFER_NPU) with QNN EP. (cherry picked from commit 8570298)
snnn
pushed a commit
that referenced
this pull request
Sep 8, 2025
### Description Fixes memory leak in `OrtEpFactory::GetSupportedDevices()`. The `OrtKeyValuePairs` instance created by the factory was not released. This memory leak can be reproduced by running the unit test [QnnHTPBackendTests.AutoEp_PreferNpu](https://github.com/microsoft/onnxruntime/blob/4e2699fbf24d96d2a0261b30509864da08b701de/onnxruntime/test/providers/qnn/qnn_basic_test.cc#L1426). ### Motivation and Context Fix memory leak that one encounters when using automatic EP selection (e.g., PREFER_NPU) with QNN EP. (cherry picked from commit 8570298)
snnn
pushed a commit
that referenced
this pull request
Sep 8, 2025
### Description Fixes memory leak in `OrtEpFactory::GetSupportedDevices()`. The `OrtKeyValuePairs` instance created by the factory was not released. This memory leak can be reproduced by running the unit test [QnnHTPBackendTests.AutoEp_PreferNpu](https://github.com/microsoft/onnxruntime/blob/4e2699fbf24d96d2a0261b30509864da08b701de/onnxruntime/test/providers/qnn/qnn_basic_test.cc#L1426). ### Motivation and Context Fix memory leak that one encounters when using automatic EP selection (e.g., PREFER_NPU) with QNN EP. (cherry picked from commit 8570298)
snnn
added a commit
that referenced
this pull request
Sep 8, 2025
This PR cherry-picks the following PRs to the rel-1.23.0 branch: * #25938 * #25957 * #25960 * #25968 * #25971 --------- Co-authored-by: Dmitri Smirnov <[email protected]> Co-authored-by: Adrian Lizarraga <[email protected]> Co-authored-by: Hariharan Seshadri <[email protected]>
Member
|
This PR has been cherry-picked into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes memory leak in
OrtEpFactory::GetSupportedDevices(). TheOrtKeyValuePairsinstance created by the factory was not released.This memory leak can be reproduced by running the unit test QnnHTPBackendTests.AutoEp_PreferNpu.
Motivation and Context
Fix memory leak that one encounters when using automatic EP selection (e.g., PREFER_NPU) with QNN EP.