Revert accidental memory alignment change for x86 for prepacked weights buffer #25971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed if statement to if constexpr for compile-time evaluation.
jywu-msft
approved these changes
Sep 7, 2025
snnn
pushed a commit
to snnn/onnxruntime
that referenced
this pull request
Sep 8, 2025
…ts buffer (microsoft#25971) ### Description The memory alignment for the pre-packed weights buffer was accidentally changed for 8-bit Gemms on x86 while supporting the ARM64 equivalent 8-bit Gemm kernel in microsoft#25110. This change in alignment could either cause perf penalty or seg-fault depending on the platform while the corresponding aligned data load instruction is executed in the Gemm kernel. This changes fixes it as well as adds back a couple of tests to the MLAS 8-bit Gemm test suite and fixes a minor nit in the test file. ### Motivation and Context Resolve packaging pipeline crash (cherry picked from commit 96f4595)
snnn
pushed a commit
that referenced
this pull request
Sep 8, 2025
…ts buffer (#25971) ### Description The memory alignment for the pre-packed weights buffer was accidentally changed for 8-bit Gemms on x86 while supporting the ARM64 equivalent 8-bit Gemm kernel in #25110. This change in alignment could either cause perf penalty or seg-fault depending on the platform while the corresponding aligned data load instruction is executed in the Gemm kernel. This changes fixes it as well as adds back a couple of tests to the MLAS 8-bit Gemm test suite and fixes a minor nit in the test file. ### Motivation and Context Resolve packaging pipeline crash (cherry picked from commit 96f4595)
snnn
pushed a commit
that referenced
this pull request
Sep 8, 2025
…ts buffer (#25971) ### Description The memory alignment for the pre-packed weights buffer was accidentally changed for 8-bit Gemms on x86 while supporting the ARM64 equivalent 8-bit Gemm kernel in #25110. This change in alignment could either cause perf penalty or seg-fault depending on the platform while the corresponding aligned data load instruction is executed in the Gemm kernel. This changes fixes it as well as adds back a couple of tests to the MLAS 8-bit Gemm test suite and fixes a minor nit in the test file. ### Motivation and Context Resolve packaging pipeline crash (cherry picked from commit 96f4595)
snnn
added a commit
that referenced
this pull request
Sep 8, 2025
This PR cherry-picks the following PRs to the rel-1.23.0 branch: * #25938 * #25957 * #25960 * #25968 * #25971 --------- Co-authored-by: Dmitri Smirnov <[email protected]> Co-authored-by: Adrian Lizarraga <[email protected]> Co-authored-by: Hariharan Seshadri <[email protected]>
Member
|
This PR has been cherry-picked into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The memory alignment for the pre-packed weights buffer was accidentally changed for 8-bit Gemms on x86 while supporting the ARM64 equivalent 8-bit Gemm kernel in #25110. This change in alignment could either cause perf penalty or seg-fault depending on the platform while the corresponding aligned data load instruction is executed in the Gemm kernel.
This changes fixes it as well as adds back a couple of tests to the MLAS 8-bit Gemm test suite and fixes a minor nit in the test file.
Motivation and Context
Resolve packaging pipeline crash