chore: set v1.55.0 #3234
Merged
chore: set v1.55.0 #3234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Aug 27, 2025
Member
yury-s
left a comment
yury-s
left a comment
There was a problem hiding this comment.
Are you sure it should be on the main branch?
Skn0tt
approved these changes
Aug 28, 2025
rajsite
reviewed
Oct 3, 2025
| <AssemblyVersion>1.55.0</AssemblyVersion> | ||
| <PackageVersion>$(AssemblyVersion)-beta-4</PackageVersion> | ||
| <PackageVersion>$(AssemblyVersion)</PackageVersion> | ||
| <DriverVersion>1.55.0-beta-1756314050000</DriverVersion> |
There was a problem hiding this comment.
@mxschmitt is it intentional that that the 1.55.0 release is using a beta DriverVersion? We try and align our playwright node and dotnet versions to the DriverVersion so we aren't mixing browsers used in different tests.
Contributor
Author
There was a problem hiding this comment.
Yes, this is intentional, the internal driver version can be a beta which means its still from the release-* branch.
There was a problem hiding this comment.
Our goal is to keep the browsers and playwright version aligned during upgrades between node playwright usage and dotnet playwright usage. That means we would upgrade our pinned devDep version in node apps to "playwright": "1.55.0-beta-1756314050000" in order to align with dotnet.
Switching to a beta to preserve that consistency doesn't feel ideal and it's already a bit challenging to need to dig through source / package contents to find the npm published version to rely on.
Provided that framing to ask: would you suggest a different workflow to achieve that consistency or maybe I should post a feature request for that to be easier / an explicit workflow (playwright dotnet README includes the DriverVersion, etc)?
1 task
rajsite
added a commit
to ni/nimble
that referenced
this pull request
Oct 3, 2025
Performs the following changes: - Updates npm dependencies, except: - Known don't upgrades: angular v20 (and ng-packagr and zone.js), ni eslint v9 packages, tiptap v3, react v19, typescript >v5.4.5 - `@vitejs/plugin-react-swc` upgrading caused type and build errors I did not investigate - yargs major update requires source changes, didn't look into it - newly pinned peer `flatbuffers`. [TypeScript 5.7 changed the definitions of Int32Array to include a generic](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-7.html#support-for---target-es2024-and---lib-es2024). The flatbuffers library used by apache-arrow [updated to a newer version of typescript](google/flatbuffers#8620) and now emits types that rely on Int32 being generic. Because we do full type lib checks this causes an issue and TypeScript fails with `Error TS2315: Type 'Int32Array' is not generic.` messages. Added a peer dep on the older `flatbuffers` version to avoid the issue. When the Angular upgrade is done and corresponding TypeScript update we can remove that pinned per `flatbuffers` dep. - Updates nuget deps, except: - Known don't upgrades: dotnet v9 - Following the [Manual Recurring update task on playwright](#1747) I tried to find the latest playwright version is 1.55.0 which has a [DriverVersion / node dependency version on `[email protected]`](https://github.com/microsoft/playwright-dotnet/blob/v1.55.0/src/Common/Version.props#L5). This [seems intentional](microsoft/playwright-dotnet#3234 (comment)) right now so I instead went with the [last release](https://github.com/microsoft/playwright-dotnet/blob/v1.54.0/src/Common/Version.props#L5) of `[email protected]` and `[email protected]` - This update ends up pulling in the stylistic update in the ni eslint packages and applies formatting changes for it. - Updates `template.ts` files to opt-out of prettier linting altogether (33 of 62 files already manually were) and the `@stylistic/indent` eslint rule. - Known workflow issues: With the latest Visual Studio installed and with the dotnet-sdk v8 version we specify in the globals.json file it is not possible to run `npm run -w packages\blazor-workspace update-lock-files` reliably. It will lock to assembly versions that are not part of the sdk installation, see [dotnet issue](dotnet/sdk#38200). The best workaround I have so far is to sync the changes in WSL, [nuke any existing dotnet installs in WSL](dotnet/sdk#39635 (comment)), download the x64 sdk, [manually install it](https://learn.microsoft.com/en-us/dotnet/core/install/linux-scripted-manual#example), and then update lock files to push to the branch. - Updates renovate.json to opt-out of package-lock.json updates and npm `@ni` package updates as separate workflows. Getting the notification for general package.json updates periodically is good enough as updates are a very manual process right now. <details> <summary>Renovate Blazor Update Details</summary> > [!NOTE] > Mend has cancelled [the proposed renaming](https://github.com/renovatebot/renovate/discussions/37842) of the Renovate GitHub app being renamed to `mend[bot]`. > > This notice will be removed on 2025-10-07. <hr> This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [Microsoft.AspNetCore.Components.Web](https://asp.net/) ([source](https://github.com/dotnet/aspnetcore)) | `8.0.19` -> `8.0.20` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.AspNetCore.Components.WebAssembly.DevServer](https://asp.net/) ([source](https://github.com/dotnet/aspnetcore)) | `8.0.19` -> `8.0.20` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.AspNetCore.Components.WebAssembly.Server](https://asp.net/) ([source](https://github.com/dotnet/aspnetcore)) | `8.0.19` -> `8.0.20` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.AspNetCore.Components.WebView](https://asp.net/) ([source](https://github.com/dotnet/aspnetcore)) | `8.0.19` -> `8.0.20` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.AspNetCore.Mvc.Testing](https://asp.net/) ([source](https://github.com/dotnet/aspnetcore)) | `8.0.19` -> `8.0.20` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [xunit.runner.visualstudio](https://github.com/xunit/visualstudio.xunit) | `3.1.3` -> `3.1.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>dotnet/aspnetcore (Microsoft.AspNetCore.Components.Web)</summary> ### [`v8.0.20`](https://github.com/dotnet/aspnetcore/releases/tag/v8.0.20): .NET 8.0.20 [Release](https://github.com/dotnet/core/releases/tag/v8.0.20) ##### What's Changed - Update branding to 8.0.20 by [@​vseanreesermsft](https://github.com/vseanreesermsft) in [#​63106](https://github.com/dotnet/aspnetcore/pull/63106) - \[release/8.0] (deps): Bump src/submodules/googletest from `c67de11` to `373af2e` by [@​dependabot](https://github.com/dependabot)\[bot] in [#​63038](https://github.com/dotnet/aspnetcore/pull/63038) - \[release/8.0] Dispose the certificate chain elements with the chain by [@​MackinnonBuck](https://github.com/MackinnonBuck) in [#​62994](https://github.com/dotnet/aspnetcore/pull/62994) - \[release/8.0] Update SignalR Redis tests to use internal Docker Hub mirror by [@​github-actions](https://github.com/github-actions)\[bot] in [#​63117](https://github.com/dotnet/aspnetcore/pull/63117) - \[release/8.0] \[SignalR] Don't throw for message headers in Java client by [@​github-actions](https://github.com/github-actions)\[bot] in [#​62784](https://github.com/dotnet/aspnetcore/pull/62784) - Merging internal commits for release/8.0 by [@​vseanreesermsft](https://github.com/vseanreesermsft) in [#​63152](https://github.com/dotnet/aspnetcore/pull/63152) - \[release/8.0] Update dependencies from dotnet/extensions by [@​dotnet-maestro](https://github.com/dotnet-maestro)\[bot] in [#​63188](https://github.com/dotnet/aspnetcore/pull/63188) - \[release/8.0] Update dependencies from dotnet/arcade by [@​dotnet-maestro](https://github.com/dotnet-maestro)\[bot] in [#​63189](https://github.com/dotnet/aspnetcore/pull/63189) **Full Changelog**: <dotnet/aspnetcore@v8.0.19...v8.0.20> </details> <details> <summary>xunit/visualstudio.xunit (xunit.runner.visualstudio)</summary> ### [`v3.1.5`](https://github.com/xunit/visualstudio.xunit/compare/3.1.4...3.1.5) [Compare Source](https://github.com/xunit/visualstudio.xunit/compare/3.1.4...3.1.5) ### [`v3.1.4`](https://github.com/xunit/visualstudio.xunit/compare/3.1.3...3.1.4) [Compare Source](https://github.com/xunit/visualstudio.xunit/compare/3.1.3...3.1.4) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "monthly" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/ni/nimble). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMzEuOSIsInVwZGF0ZWRJblZlciI6IjQxLjEzMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> </details> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: rajsite <[email protected]> Co-authored-by: rajsite <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.