Skip to content

chore: set v1.55.0 #3234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxschmitt merged 2 commits into from
Aug 28, 2025
Merged

chore: set v1.55.0 #3234

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7a0174
chore: set v1.55.0
mxschmitt Aug 27, 2025
c32e409
Merge branch 'main' into mxschmitt-patch-2
mxschmitt Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Common/Version.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>
<PropertyGroup>
<AssemblyVersion>1.55.0</AssemblyVersion>
<PackageVersion>$(AssemblyVersion)-beta-4</PackageVersion>
<PackageVersion>$(AssemblyVersion)</PackageVersion>
<DriverVersion>1.55.0-beta-1756314050000</DriverVersion>
Copy link

@rajsite rajsite Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mxschmitt is it intentional that that the 1.55.0 release is using a beta DriverVersion? We try and align our playwright node and dotnet versions to the DriverVersion so we aren't mixing browsers used in different tests.

Copy link
Contributor Author

@mxschmitt mxschmitt Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is intentional, the internal driver version can be a beta which means its still from the release-* branch.

Copy link

@rajsite rajsite Oct 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our goal is to keep the browsers and playwright version aligned during upgrades between node playwright usage and dotnet playwright usage. That means we would upgrade our pinned devDep version in node apps to "playwright": "1.55.0-beta-1756314050000" in order to align with dotnet.

Switching to a beta to preserve that consistency doesn't feel ideal and it's already a bit challenging to need to dig through source / package contents to find the npm published version to rely on.

Provided that framing to ask: would you suggest a different workflow to achieve that consistency or maybe I should post a feature request for that to be easier / an explicit workflow (playwright dotnet README includes the DriverVersion, etc)?

<ReleaseVersion>$(AssemblyVersion)</ReleaseVersion>
<FileVersion>$(AssemblyVersion)</FileVersion>
Expand Down
Loading