Skip to content

Conversation

@Saadnajmi
Copy link
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

I was looking into our Circle CI E2E tests, when I noticed we had this strange diff. Our metro config was loading two modules (InitializeCore + Image Asset Registry) before other modules. Looking deeper, I saw React Native Windows had a bug around this too. They added that behavior to their metro config in microsoft/react-native-windows#4814 , fixed the issue upstream in the CLI with react-native-community/cli#1115 , and then backed out the change in React Native Windows in microsoft/react-native-windows#4939 .

After the CLI change went in, it seems like we too should not need to load these modules first, so I am removing this change.

Changelog

[General] [Fixed] - Removed unnecessary diff from upstream in our metro config

Test Plan

This change was originally added to fix fast refresh, so I'm hoping testing fast refresh on rn-tester + CI checks should be enough. I'll also tag @acoates-ms who made the CLI / RNW changes to verify I'm not being dumb or missed anything.

@Saadnajmi
Copy link
Collaborator Author

This is causing issues locally, so I will close this for now and follow up after investigation.

@Saadnajmi Saadnajmi closed this Jan 15, 2022
@Saadnajmi Saadnajmi deleted the revert-metro-change branch January 15, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant