Skip to content

Revert unneeded diff in metro config #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Revert unneeded diff in metro config #959

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edd44f8
undo metro change
Saadnajmi Jan 15, 2022
3c3fada
keep test commented out
Saadnajmi Jan 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
undo metro change
  • Loading branch information
@Saadnajmi
Saadnajmi committed Jan 15, 2022
commit edd44f819464fd454be65b165ddeabe2c72c7390
9 changes: 0 additions & 9 deletions metro.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,4 @@ const config = {
transformer: {},
};

// In scripts/run-ci-e2e-tests.js this file gets copied to a new app, in which
// case these settings do not apply.
if (!process.env.REACT_NATIVE_RUNNING_E2E_TESTS) {
const InitializeCore = require.resolve('./Libraries/Core/InitializeCore');
const AssetRegistry = require.resolve('./Libraries/Image/AssetRegistry');
config.serializer.getModulesRunBeforeMainModule = () => [InitializeCore];
config.transformer.assetRegistryPath = AssetRegistry;
}

module.exports = config;
20 changes: 6 additions & 14 deletions scripts/run-ci-e2e-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,6 @@ try {
mv('_flowconfig', '.flowconfig');
mv('_watchmanconfig', '.watchmanconfig');

// [TODO(macOS GH#774)
process.env.REACT_NATIVE_RUNNING_E2E_TESTS = 'true';
// ]TODO(macOS GH#774)

describe('Install React Native package');
exec(`npm install ${REACT_NATIVE_PACKAGE}`);

Expand Down Expand Up @@ -280,16 +276,12 @@ try {
exitCode = 1;
throw Error(exitCode);
}
// [TODO(macOS GH#949)
// Comment out failing test to unblock CI
// It seems It's running the flow checks against react-native-macos 0.63 instead of what is in the repo causing a failure
// describe('Test: Flow check');
// if (exec(`${ROOT}/node_modules/.bin/flow check`).code) {
// echo('Flow check failed.');
// exitCode = 1;
// throw Error(exitCode);
// }
// ]TODO(macOS GH#949)
describe('Test: Flow check');
if (exec(`${ROOT}/node_modules/.bin/flow check`).code) {
echo('Flow check failed.');
exitCode = 1;
throw Error(exitCode);
}
}
exitCode = 0;
} finally {
Expand Down