Skip to content

TestContext Properties type fixed to be IDictionary #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cltshivash merged 5 commits into from
Feb 9, 2019
Merged

TestContext Properties type fixed to be IDictionary #563

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fbd60d6
Ensured that the TestContext exposed is always IDictionary for back c…
cltshivash Feb 7, 2019
fb8ae92
Fixed a build failure due to TestContext signature changes
cltshivash Feb 7, 2019
f613e41
Fixed a test failure
cltshivash Feb 8, 2019
4c01db8
Updated the desktop implementation as well.
cltshivash Feb 8, 2019
d83d693
Removed some redudant cast and ToList operations in the test code.
cltshivash Feb 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated the desktop implementation as well.
  • Loading branch information
@cltshivash
cltshivash committed Feb 8, 2019
commit 4c01db8cabc9ff1a9a62f3d0c0aea5616ee6db8b
4 changes: 2 additions & 2 deletions src/Adapter/PlatformServices.Desktop/Services/DesktopTestContextImplementation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,11 @@ public override DataRow DataRow
}

/// <inheritdoc/>
public override IDictionary<string, object> Properties
public override IDictionary Properties
{
get
{
return this.properties;
return this.properties as IDictionary;
}
}

Expand Down
3 changes: 2 additions & 1 deletion src/TestFramework/Extension.Desktop/TestContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
namespace Microsoft.VisualStudio.TestTools.UnitTesting
{
using System;
using System.Collections;
using System.Collections.Generic;
using System.Data;
using System.Data.Common;
Expand All @@ -19,7 +20,7 @@ public abstract class TestContext
/// <summary>
/// Gets test properties for a test.
/// </summary>
public abstract IDictionary<string, object> Properties { get; }
public abstract IDictionary Properties { get; }

/// <summary>
/// Gets the current data row when test is used for data driven testing.
Expand Down
12 changes: 6 additions & 6 deletions test/UnitTests/PlatformServices.Desktop.Unit.Tests/Services/DesktopTestContextImplTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@ public void TestContextConstructorShouldInitializeDefaultProperties()
Assert.IsNotNull(this.testContextImplementation.Properties);

CollectionAssert.Contains(
this.testContextImplementation.Properties.ToList(),
((IDictionary<string, object>)this.testContextImplementation.Properties).ToList(),
new KeyValuePair<string, object>("FullyQualifiedTestClassName", "A.C.M"));
CollectionAssert.Contains(
this.testContextImplementation.Properties.ToList(),
((IDictionary<string, object>)this.testContextImplementation.Properties).ToList(),
new KeyValuePair<string, object>("TestName", "M"));
}

Expand Down Expand Up @@ -115,8 +115,9 @@ public void PropertiesShouldReturnPropertiesPassedToTestContext()

this.testContextImplementation = new TestContextImplementation(this.testMethod.Object, new System.IO.StringWriter(), this.properties);

CollectionAssert.Contains(this.testContextImplementation.Properties.ToList(), property1);
CollectionAssert.Contains(this.testContextImplementation.Properties.ToList(), property2);
var propertyList = ((IDictionary<string, object>)this.testContextImplementation.Properties).ToList();
CollectionAssert.Contains(propertyList, property1);
CollectionAssert.Contains(propertyList, property2);
}

[TestMethod]
Expand Down Expand Up @@ -158,11 +159,10 @@ public void TryGetPropertyValueShouldReturnFalseIfPropertyIsNotPresent()
public void AddPropertyShouldAddPropertiesToThePropertyBag()
{
this.testContextImplementation = new TestContextImplementation(this.testMethod.Object, new System.IO.StringWriter(), this.properties);

this.testContextImplementation.AddProperty("SomeNewProperty", "SomeValue");

CollectionAssert.Contains(
this.testContextImplementation.Properties.ToList(),
((IDictionary<string, object>)this.testContextImplementation.Properties).ToList(),
new KeyValuePair<string, object>("SomeNewProperty", "SomeValue"));
}

Expand Down