Skip to content

TestContext Properties type fixed to be IDictionary #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cltshivash merged 5 commits into from
Feb 9, 2019
Merged

TestContext Properties type fixed to be IDictionary #563

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fbd60d6
Ensured that the TestContext exposed is always IDictionary for back c…
cltshivash Feb 7, 2019
fb8ae92
Fixed a build failure due to TestContext signature changes
cltshivash Feb 7, 2019
f613e41
Fixed a test failure
cltshivash Feb 8, 2019
4c01db8
Updated the desktop implementation as well.
cltshivash Feb 8, 2019
d83d693
Removed some redudant cast and ToList operations in the test code.
cltshivash Feb 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed a build failure due to TestContext signature changes
  • Loading branch information
@cltshivash
cltshivash committed Feb 7, 2019
commit fb8ae9233ec2928f3b0f3f538254a4ac4e530f51
4 changes: 2 additions & 2 deletions test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Execution/TypeCacheTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,7 +922,7 @@ public void GetTestMethodInfoShouldSetTestContextWithCustomProperty()
new Dictionary<string, object>());

this.typeCache.GetTestMethodInfo(testMethod, testContext, false);
var customProperty = testContext.Properties.FirstOrDefault(p => p.Key.Equals("WhoAmI"));
var customProperty = ((IDictionary<string, object>)testContext.Properties).FirstOrDefault(p => p.Key.Equals("WhoAmI"));

Assert.IsNotNull(customProperty);
Assert.AreEqual("Me", customProperty.Value);
Expand Down Expand Up @@ -1009,7 +1009,7 @@ public void GetTestMethodInfoShouldNotAddDuplicateTestPropertiesToTestContext()

// Verify that the first value gets set.
object value;
Assert.IsTrue(testContext.Properties.TryGetValue("WhoAmI", out value));
Assert.IsTrue(((IDictionary<string, object>)testContext.Properties).TryGetValue("WhoAmI", out value));
Assert.AreEqual("Me", value);
}

Expand Down