ensure we hide options picker if session has nothing to contribute #272977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the options picker UI is hidden when a chat session has no options to contribute. The implementation adds a new method hasAnySessionOptions() to check if a session has any available options before displaying the picker.
Key Changes:
- Added
hasAnySessionOptions()method to check for session options availability - Implemented early return in
chatInputPart.tsto hide options picker when no options exist - Added corresponding test mock implementation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/common/chatSessionsService.ts |
Added interface method declaration for checking session options existence |
src/vs/workbench/contrib/chat/browser/chatSessions.contribution.ts |
Implemented hasAnySessionOptions() to check if session has available options |
src/vs/workbench/contrib/chat/browser/chatInputPart.ts |
Added guard clause to hide options picker when session has no options |
src/vs/workbench/contrib/chat/test/common/mockChatSessionsService.ts |
Implemented mock method for testing session options check |
lramos15
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as 0760da1