Skip to content

ensure we hide options picker if session has nothing to contribute #272977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
+18 −0
Merged

ensure we hide options picker if session has nothing to contribute #272977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/vs/workbench/contrib/chat/browser/chatInputPart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,6 +1139,10 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
return hideAll();
}

if (!this.chatSessionsService.hasAnySessionOptions(ctx.chatSessionType, ctx.chatSessionId)) {
return hideAll();
}

this.chatSessionHasOptions.set(true);

const currentWidgetGroupIds = new Set(this.chatSessionPickerWidgets.keys());
Expand Down
7 changes: 7 additions & 0 deletions src/vs/workbench/contrib/chat/browser/chatSessions.contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,6 +795,13 @@ export class ChatSessionsService extends Disposable implements IChatSessionsServ
this._sessions.delete(sessionKey);
}

public hasAnySessionOptions(chatSessionType: string, id: string): boolean {
const sessionKey = `${chatSessionType}_${id}`;
const session = this._sessions.get(sessionKey);
return !!session && !!session.options && Object.keys(session.options).length > 0;
}


public getSessionOption(chatSessionType: string, id: string, optionId: string): string | undefined {
const sessionKey = `${chatSessionType}_${id}`;
const session = this._sessions.get(sessionKey);
Expand Down
1 change: 1 addition & 0 deletions src/vs/workbench/contrib/chat/common/chatSessionsService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ export interface IChatSessionsService {
// Notify providers about session items changes
notifySessionItemsChanged(chatSessionType: string): void;

hasAnySessionOptions(chatSessionType: string, sessionId: string): boolean;
getSessionOption(chatSessionType: string, sessionId: string, optionId: string): string | undefined;
setSessionOption(chatSessionType: string, sessionId: string, optionId: string, value: string): boolean;

Expand Down
6 changes: 6 additions & 0 deletions src/vs/workbench/contrib/chat/test/common/mockChatSessionsService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,12 @@ export class MockChatSessionsService implements IChatSessionsService {
return true;
}

hasAnySessionOptions(chatSessionType: string, sessionId: string): boolean {
const sessionKey = `${chatSessionType}:${sessionId}`;
const options = this.sessionOptions.get(sessionKey);
return options !== undefined && options.size > 0;
}

getCapabilitiesForSessionType(chatSessionType: string): IChatAgentAttachmentCapabilities | undefined {
return this.contributions.find(c => c.type === chatSessionType)?.capabilities;
}
Expand Down
Loading