-
Notifications
You must be signed in to change notification settings - Fork 354
Storybook integration first draft (component playground) #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is super cool! Storybook is a nifty piece of tech 😊 I noticed the mgt-login and mgt-people didn't work for me though. The console shows an error: Is this expected? |
No it's not expected. I see now that there are some problems in IE11 as well. Let me take a look. |
|
@shweaver-MSFT can you try again in Edge? |
|
Looking great for a per-release. Things to do before merging:
|
|
@beth-panx I ran through the sample again and it works great! |
|
PR to update 'props' to 'properties' is created here. |
|
🎆 🍾 |
Storybook integration (component playground)
Storybook integration (component playground)
Storybook integration (component playground)
PR Type
Feature
Description of the changes
Created a storybook to showcase components. This allows users to interact with components by tweaking 'knobs' in UI and see live changes. Enables accessibility check with A11y. Provides code snippet for popular scenarios.
PR checklist
npm run build) and changes have been tested in supported browsers (including IE11)npm run setLicense)Other information
This is an early stage for storybook. Still in the process of gathering feedback and making changes. 🌚