Skip to content

Conversation

@beth-panx
Copy link
Contributor

@beth-panx beth-panx commented Dec 19, 2019

PR Type

Feature

Description of the changes

Created a storybook to showcase components. This allows users to interact with components by tweaking 'knobs' in UI and see live changes. Enables accessibility check with A11y. Provides code snippet for popular scenarios.

PR checklist

  • Project builds (npm run build) and changes have been tested in supported browsers (including IE11)
  • All public classes and methods have been documented (😎code does not touch main repo)
  • Added appropriate documentation (😎code does not touch main repo)
  • License header has been added to all new source files (npm run setLicense)
  • Contains NO breaking changes

Other information

This is an early stage for storybook. Still in the process of gathering feedback and making changes. 🌚

@beth-panx beth-panx self-assigned this Dec 19, 2019
@shweaver-MSFT
Copy link
Contributor

This is super cool! Storybook is a nifty piece of tech 😊

I noticed the mgt-login and mgt-people didn't work for me though. The console shows an error:
TypeError: Cannot read property 'api' of undefined

Is this expected?

@beth-panx
Copy link
Contributor Author

This is super cool! Storybook is a nifty piece of tech 😊

I noticed the mgt-login and mgt-people didn't work for me though. The console shows an error:
TypeError: Cannot read property 'api' of undefined

Is this expected?

No it's not expected. I see now that there are some problems in IE11 as well. Let me take a look.

@beth-panx
Copy link
Contributor Author

@shweaver-MSFT can you try again in Edge?
FYI - I am aware there is loading problem in IE11 as it seems like a SB issue and it's filed here.

@nmetulev
Copy link
Contributor

nmetulev commented Jan 7, 2020

Looking great for a per-release. Things to do before merging:

  • disable sign in until fixed in toolkit
  • create a new client id to be used only for storybook
  • in docs tab, change 'props' to 'properties'

@shweaver-MSFT
Copy link
Contributor

@beth-panx I ran through the sample again and it works great!

@beth-panx
Copy link
Contributor Author

PR to update 'props' to 'properties' is created here.

@beth-panx beth-panx merged commit a2ce8d6 into master Jan 13, 2020
@beth-panx beth-panx deleted the playground branch January 13, 2020 19:25
@nmetulev
Copy link
Contributor

🎆 🍾

shweaver-MSFT pushed a commit that referenced this pull request Jun 8, 2020
Storybook integration (component playground)
shweaver-MSFT pushed a commit that referenced this pull request Jun 10, 2020
Storybook integration (component playground)
shweaver-MSFT pushed a commit that referenced this pull request Jun 10, 2020
Storybook integration (component playground)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants