Skip to content

Addon-docs / web-components: Rename 'props' to 'properties' in props table #9362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shilman merged 1 commit into from
Jan 9, 2020
Merged

Addon-docs / web-components: Rename 'props' to 'properties' in props table #9362

shilman merged 1 commit into from
Jan 9, 2020

Conversation

@beth-panx
Copy link
Contributor

@beth-panx beth-panx commented Jan 9, 2020

Update 'props' section title to 'properties'

Issue: Generated docs have a section 'Props'. 'Properties' is more appropriate for web component projects.

What I did

Updated wording

How to test

  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

Updated docs page:
Screen Shot 2020-01-08 at 5 56 16 PM

@beth-panx
[Addon-docs][Web Components] Update 'props' to 'properties'
1e5220b 
Update 'props' section title to 'properties'
@vercel
Copy link

vercel bot commented Jan 9, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/hfulqs517
✅ Preview: https://monorepo-git-fork-beth-panx-patch-3.storybook.now.sh

This was referenced Jan 9, 2020
Merged
Merged
@shilman shilman added addon: docs maintenance User-facing maintenance tasks labels Jan 9, 2020
@shilman shilman added this to the 5.3.0 milestone Jan 9, 2020
shilman
shilman approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!! 💯

@shilman shilman changed the title [Addon-docs][Web Components] Update 'props' to 'properties' Addon-docs / web-components: Update 'props' section to 'properties' in props table Jan 9, 2020
@shilman shilman changed the title Addon-docs / web-components: Update 'props' section to 'properties' in props table Addon-docs / web-components: Rename 'props' section to 'properties' in props table Jan 9, 2020
@shilman shilman changed the title Addon-docs / web-components: Rename 'props' section to 'properties' in props table Addon-docs / web-components: Rename 'props' to 'properties' in props table Jan 9, 2020
@shilman shilman merged commit 94adb10 into storybookjs:next Jan 9, 2020
This was referenced Jan 20, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shilman shilman shilman approved these changes

Assignees

No one assigned

Labels

addon: docs maintenance User-facing maintenance tasks

Projects

None yet

Milestone

5.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@beth-panx @shilman