Remove carriage return before each test line in spec reporter #2400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Munter ty. can you take a screenshot of before/after output in a console? also would be helpful to see the before/after output when redirecting to a file |
Member
|
also, whatever mocha-phantomjs outputs should be checked |
boneskull
added
the
status: waiting for author
2 tasks
Contributor
Author
|
#2401 replaces this PR |
Member
|
(This PR is closed because we get better CI coverage if a committer can just use a branch in |
boneskull
removed
the
status: waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec reporter would output a carriage return char at the beginning of each line in non-TTY's and delete and overwrite the current line in TTY's.
Since this cursor call was only ever used at the beginning of a line it serves no purpose.
See discussion starting at https://gitter.im/mochajs/mocha?at=579a7573ac80b5ea3f149512