chore: more fully remove assetgraph-builder and canvas#5175
Merged
JoshuaKGoldberg merged 5 commits intoAug 3, 2024
Conversation
Member
|
Scratch previous comment – but we need to adapt either this one to the other one or the reverse We should merge this prior to #5071 at least though |
Member
Author
|
If you'll pardon my reach, this one makes it annoying for me to review other PRs, so I'm going to sneak it in first. 😄 |
5 tasks
lennonnikolas
pushed a commit
to lennonnikolas/mocha
that referenced
this pull request
Jan 24, 2026
* chore: more fully remove assetgraph-builder and canvas * fixed up images too * Remove last postbuild bit * fix: netlify build.publish trailing slash
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
This is a superset of #5069 as reverted by #5095. Replaces the existing
assetgraph-builder+canvassystem in two ways:assetgraph-builderto optimize the site's assets, resizes larger images to how they're used now and runsnpx imagemin-clion all the.pngsdocs/_distdirectory, and instead has thedocs/_sitebe the final outputcanvasto determine image positioning in their fixed size parent DOM elements, uses CSSLong-term I'd want us to move to a more modern docs site builder, with or without a reorganization to multiple pages. But this works in the interim I think.