Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use semver for Node version detecting
  • Loading branch information
mark-wiemer committed Aug 6, 2025
commit 197649928c8acdabaf2572d91181ee6bd23dcf6f
13 changes: 7 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@
"rollup-plugin-node-globals": "^1.4.0",
"rollup-plugin-polyfill-node": "^0.8.0",
"rollup-plugin-visualizer": "^5.6.0",
"semver": "^7.7.2",
"sinon": "^9.0.3",
"unexpected": "^11.14.0",
"unexpected-eventemitter": "^2.2.0",
Expand Down
7 changes: 2 additions & 5 deletions test/integration/plugins/root-hooks.spec.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';

var invokeMochaAsync = require('../helpers').invokeMochaAsync;
const semver = require('semver');

/**
* Extracts root hook log messages from run results
Expand Down Expand Up @@ -144,11 +145,7 @@ describe('root hooks', function () {
function isNewerVersion(vString) {
// Latest versions considered "older": 22.11.0, 20.18.3, 18.20.8
// (May update after writing)
return (
(vString.startsWith('20') && vString > '20.18.3') ||
(vString.startsWith('22') && vString > '22.11.0') ||
(vString.startsWith('24'))
);
return semver.satisfies(vString, '^20.19.0 || ^22.12.0 || ^24.0.0');
}

describe('on older versions, should fail due to ambiguous file type', function () {
Expand Down
Loading