Skip to content

chore: Update experimental module detection test and pin exact Node versions #5417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mark-wiemer merged 8 commits into from
Aug 15, 2025
Merged

chore: Update experimental module detection test and pin exact Node versions #5417

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
67b7e85
Fix test and pin exact versions
mark-wiemer Jul 28, 2025
9aba5f2
Merge remote-tracking branch 'upstream/main' into fix-5376
mark-wiemer Jul 28, 2025
26e7056
Fix version detection function
mark-wiemer Jul 28, 2025
512388f
Pin Node 22 to 22.11.0
mark-wiemer Jul 28, 2025
cc85e0c
Downgrade Node 20, unpin Node 22
mark-wiemer Jul 28, 2025
1976499
Use semver for Node version detecting
mark-wiemer Aug 6, 2025
cc80d96
Merge branch 'main' into fix-5376
mark-wiemer Aug 9, 2025
f320d61
Clarify comments to be in ascending Node version order
mark-wiemer Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Downgrade Node 20, unpin Node 22
  • Loading branch information
@mark-wiemer
mark-wiemer committed Jul 28, 2025
commit cc85e0cd3386ef2a1a644a391ab973fd5935ea50
8 changes: 3 additions & 5 deletions .github/workflows/mocha.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ jobs:
smoke:
uses: ./.github/workflows/npm-script.yml
with:
# The 22.11.0 is instead of 22 per https://github.com/mochajs/mocha/issues/5278
node-versions: '18,20,22.11.0,24'
node-versions: '18,20,22,24'
npm-script: test-smoke

test-node-lts:
Expand Down Expand Up @@ -67,10 +66,9 @@ jobs:
with:
os: 'ubuntu-latest,windows-latest'
# We pin exact versions here per https://github.com/mochajs/mocha/issues/5052
# The 22.11.0 is instead of 22 per https://github.com/mochajs/mocha/issues/5278
# LTS is tested in a previous step
# Use 20.18.3 per https://github.com/mochajs/mocha/issues/5278
# Ref https://nodejs.org/en/about/previous-releases
node-versions: '18.20.8,20.19.4,22.11.0,24.4.1'
node-versions: '18.20.8,20.18.3,22.17.1,24.4.1'
npm-script: test-node:${{ matrix.test-part }}
coverage: ${{ matrix.coverage }}

Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/npm-script.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# The 22.11.0 is instead of "lts/*" per https://github.com/mochajs/mocha/issues/5278
node_version: ${{ fromJson(needs.resolve-inputs.outputs.nodeVersions || '["22.11.0"]') }}
node_version: ${{ fromJson(needs.resolve-inputs.outputs.nodeVersions || '["22"]') }}
os: ${{ fromJson(needs.resolve-inputs.outputs.os || '["ubuntu-latest"]') }}
browser: ${{ fromJson(needs.resolve-inputs.outputs.browsers || '[""]') }}
steps:
Expand Down
Loading