Validate transaction size#254
Merged
manuelmauro merged 8 commits intomoonbeam-polkadot-stable2506from Mar 5, 2026
Merged
Conversation
|
@manuelmauro please update ethereum pin |
- Inline format args in format!/assert! macros (uninlined_format_args) - Remove unnecessary borrow on format! result (needless_borrows_for_generic_args) - Remove useless .into() conversion for u64 (useless_conversion) - Allow dead_code on JSON_RPC_ERROR_DEFAULT constant
This reverts commit 3904a4d.
librelois
approved these changes
Mar 4, 2026
librelois
left a comment
librelois
left a comment
There was a problem hiding this comment.
I added a commit with comments to clarify intents
manuelmauro
merged commit c28328d
into
moonbeam-polkadot-stable2506
2 of 4 checks passed
manuelmauro
added a commit
that referenced
this pull request
Mar 10, 2026
Co-authored-by: Eloïs <c@elo.tf>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eth_sendTransactionandeth_sendRawTransactionRPC endpointstxMaxSizelimit)Changes
encoded_length()andvalidate_size()methods toTransactionRequestTX_SLOT_BYTE_SIZE(32 KiB) andDEFAULT_MAX_TX_INPUT_BYTES(128 KiB) constantssend_transactionbefore signingsend_raw_transactionbefore decodingReferences
Note
Depends on: moonbeam-foundation/ethereum#2