Skip to content

Validate transaction size #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manuelmauro merged 8 commits into from
Mar 5, 2026
Merged

Validate transaction size #254

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7c057ef
fix: :bug: validate transaction size
manuelmauro Jan 26, 2026
2012b03
style: :art: fmt
manuelmauro Feb 25, 2026
1030e71
refactor: :rotating_light: clippy
manuelmauro Feb 25, 2026
9ae63f6
refactor: :rotating_light: clippy
manuelmauro Feb 26, 2026
a6fa0e7
chore: :pushpin: upgrade ethereum
manuelmauro Mar 2, 2026
3904a4d
fix: resolve clippy warnings for release build
manuelmauro Mar 2, 2026
8a7af7a
Revert "fix: resolve clippy warnings for release build"
manuelmauro Mar 2, 2026
4fe3d26
clarify intents in comments
librelois Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style: 🎨 fmt
  • Loading branch information
@manuelmauro
manuelmauro committed Feb 25, 2026
commit 2012b03ad207e857440e8142fdd4074b85b3f993
6 changes: 5 additions & 1 deletion client/rpc-core/src/types/transaction_request.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,11 @@ mod tests {
);

// Verify it's a reasonable size for a minimal transaction
assert!(size < 200, "Size {} should be reasonable for minimal tx", size);
assert!(
size < 200,
"Size {} should be reasonable for minimal tx",
size
);
}

#[test]
Expand Down
6 changes: 3 additions & 3 deletions client/rpc/src/eth/submit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ where
}

pub async fn send_transaction(&self, request: TransactionRequest) -> RpcResult<H256> {
request.validate_size().map_err(|msg| {
crate::err(jsonrpsee::types::error::INVALID_PARAMS_CODE, &msg, None)
})?;
request
.validate_size()
.map_err(|msg| crate::err(jsonrpsee::types::error::INVALID_PARAMS_CODE, &msg, None))?;

let from = match request.from {
Some(from) => from,
Expand Down
Loading