Skip to content

fix(process): align capture Evidence provider admission - #1760

Merged
N0zoM1z0 merged 1 commit into
mainfrom
fix/process-capture-provider-1757
Oct 11, 2026
Merged

N0zoM1z0 merged 1 commit into
mainfrom
fix/process-capture-provider-1757

Conversation

@N0zoM1z0

Copy link
Copy Markdown
Collaborator

MCP currently derives comparison Evidence from process captures with an unrelated provider ID/version, while the CLI rejects them. Both adapters also accept arbitrary provider names despite the established current/legacy domain rule. Authenticate Evidence first, retain operation/predicate checks, then use isProcessEvidenceProvider at both admission boundaries.

Rejected providers now return a typed input issue at [left|right, "provider"] with the actual provider identity. Current rea-process v3 and its explicitly supported legacy name keep the exact successful Evidence, locations and links. No capture execution or provider authority is added.

Closes #1757. Related identity matcher: #706.

Validation:

  • Freshly compiled latest main 6ff4d4a0 in a separate worktree; actual public CLI and SDK stdio MCP reproduce wrong-ID/version admission differences and wrong-name admission. All inputs have correctly recomputed Evidence IDs.
  • Six independent wrong-provider left/right regressions fail on main. After correction, 24 tests pass across the diagnostic MCP suite, trace adapter parity and process CLI suite. Controls cover both supported names, complete authenticated Evidence/text parity, operation/result failures and digest tampering before provider checks. The process CLI suite also performs a small real Node process capture/comparison.
  • Actual CLI + SDK stdio MCP matrix after the fix rejects wrong ID/version/name consistently, preserves complete current/legacy results byte-for-byte as parsed Evidence, and answers subsequent ping. Repeated after independent Luna review with no blocking finding.
  • Full single-threaded typecheck, lint/module boundaries, changed-file format, architecture guards and diff check pass, all within the 2 GiB process-family budget.

No installed native provider, browser, Notion or Obsidian verification is claimed. Public comparison probes use authenticated static process-capture fixtures; the separate existing CLI test supplies the live Node capture coverage. Schemas and successful output contracts are unchanged; unsupported provider admission is intentionally corrected.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T08:03:08.520829Z 82a3df7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@N0zoM1z0
N0zoM1z0 merged commit 713db4d into main Oct 11, 2026
31 checks passed
@N0zoM1z0
N0zoM1z0 deleted the fix/process-capture-provider-1757 branch October 11, 2026 08:14
@morluto morluto mentioned this pull request Oct 13, 2026
3 tasks done
@morluto morluto added bug Something isn't working area: runtime Process capture and runtime observation labels Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: runtime Process capture and runtime observation bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(process): align capture Evidence provider admission across CLI and MCP

2 participants