Repository navigation
fix(process): align capture Evidence provider admission - #1760
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCP currently derives comparison Evidence from process captures with an unrelated provider ID/version, while the CLI rejects them. Both adapters also accept arbitrary provider names despite the established current/legacy domain rule. Authenticate Evidence first, retain operation/predicate checks, then use
isProcessEvidenceProviderat both admission boundaries.Rejected providers now return a typed input issue at
[left|right, "provider"]with the actual provider identity. Currentrea-processv3 and its explicitly supported legacy name keep the exact successful Evidence, locations and links. No capture execution or provider authority is added.Closes #1757. Related identity matcher: #706.
Validation:
6ff4d4a0in a separate worktree; actual public CLI and SDK stdio MCP reproduce wrong-ID/version admission differences and wrong-name admission. All inputs have correctly recomputed Evidence IDs.No installed native provider, browser, Notion or Obsidian verification is claimed. Public comparison probes use authenticated static process-capture fixtures; the separate existing CLI test supplies the live Node capture coverage. Schemas and successful output contracts are unchanged; unsupported provider admission is intentionally corrected.