Repository navigation
fix(evidence): admit current process provider identity - #706
Merged
kaoru0822-kitauji merged 1 commit intoOct 6, 2026
Merged
kaoru0822-kitauji merged 1 commit into
kaoru0822-kitauji merged 1 commit into
Conversation
Collaborator
Author
|
@codex review |
2 tasks done
darsrc
pushed a commit
to darsrc/rea
that referenced
this pull request
Oct 10, 2026
…dence-provider-identity fix(evidence): admit current process provider identity
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow the public process-comparison producer's current provider identity through the three investigation consumers, while preserving exact legacy v3 compatibility.
No separate issue: this is a reproduced producer/consumer contract mismatch.
Problem and expected behavior
#572 renamed the process provider to
REA process capturewhile retainingrea-process, version3, and the process-comparison predicate. Three consumers still requireREA deterministic process harness.As a result, the exact Evidence returned by public
compare_process_capturesis rejected asinvalid_requestbyfind_changed_behavior,correlate_static_and_runtime, andverify_reconstruction. Changing only the name to the legacy spelling and correctly recomputing the Evidence ID makes that same valid comparison pass.Change and scope
Move the canonical process identity into the domain layer, keeping the existing application
PROCESS_PROVIDERexport as a re-export.Use one process-specific matcher in the three admission branches: exact provider ID, version 3, and either the exact current name or exact legacy name. Other provider matching remains unchanged.
This is compatibility for records satisfying the current v3 schema and admission rules; it does not restore removed replay features or introduce prefix/generalized provider matching.
Contract and boundary impact
Evidence and regression coverage
The new MCP suite fails two current-name cases on unchanged main
cf06115, while 22 controls pass. A separate baseline reproducer checks rejection through each of the three routes independently.Tests use owned valid capture JSON fixtures, the public file-comparison workflow, and an in-memory MCP SDK client/server. CLI-service and MCP comparison Evidence are equal, then the exact returned Evidence is consumed by all three tools.
Both exact provider names are covered. Ten independently rehashed invalid identity/authority variants per name are rejected across all three routes: unrelated name/ID, old/future/missing version, wrong predicate/operation, non-null subject, wrong confidence and wrong authority. Separate digest tampering is rejected before admission through validator/session/bundle boundaries.
Validation performed
npm run check: passed; all five tasks succeeded (106 warnings, no errors).npm run jscpd,npm run scan:todos, andgit diff --check: passed.Node.js 24.19.0, npm 11.9.0, exact locked dependencies. Hosted CI is tracked separately; no full local suite pass is claimed.
Compatibility, safety, and release
No schema, dependency, packaging, runtime-ownership or execution-authority changes. Fixtures contain synthetic valid capture data; no binary provider or browser was launched. Package-install and real-provider lanes were not rerun for this identity-admission correction.
Prepared with AI assistance.