Skip to content

fix(test): audit static Wasm and Harmony tool wording - #1917

Merged
N0zoM1z0 merged 1 commit into
mainfrom
fix/tool-effects-static-wording
Oct 11, 2026
Merged

N0zoM1z0 merged 1 commit into
mainfrom
fix/tool-effects-static-wording

Conversation

@N0zoM1z0

@N0zoM1z0 N0zoM1z0 commented Oct 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The effects-wording audit rejects inspect_wasm_artifact (“No … WASM execution”) and project_harmony_application_graph (“execution-free … inventory”). Add their documented nonexecution reasons to the existing manual audit. This fixes the sole test failure in the #1912 CI run.

Problem and expected behavior

Execution vocabulary in a negative statement does not declare foreign-code execution. The audit should accept these reviewed static tool descriptions and continue rejecting unaudited execution wording or stale exceptions.

Change and scope

Three lines in the existing test-only exception map. Source review confirms WABT uses validation/disassembly/WAT tools and Harmony projects authenticated inventory Evidence. The canonical effects and audit assertions are retained. CI-audit maintenance is tracked by the linked failed run.

Contract and boundary impact

  • Semantic owner: tool-description wording audit in toolEffects.test.ts.
  • CLI/MCP, provider, Evidence, process authority and generated/package/install contracts: none.

Evidence and regression coverage

Latest main 9d8e42b: one failure, four passing tests, with exactly these two tool names rejected. After the fix, all five effects tests pass, including complete tool inventory, annotation derivation and stale-exception checks.

  • Claims distinguish source review from runtime verification.
  • Failure evidence and declared effects are preserved.
  • Runtime/provider proof scope is explicit.

Validation performed

  • npm run test:local -- src/contracts/toolEffects.test.ts — 1 failed/4 passed before; 5 passed after.
  • Normal pre-commit formatting/lint — pass.
  • Normal pre-push typecheck/lint — pass. Independent and automated review of d66102c — no remaining blocker. Exact-head CI: ten successful checks, 18 skipped; all four test shards and the required CI check pass.

Compatibility, safety, and release

Test-audit scope; no migration, package or release metadata change. No target or provider execution performed for this audit correction.

Review checklist

  • Concrete CI failure, focused conventional title and linked reproduction.
  • Existing assertions verify the regression and stale audit entries.
  • Owning test updated; public/generated contracts require no edit.
  • Diff checked for secrets, unrelated changes and unsupported claims.

Account for explicit nonexecution wording in the existing tool-effects audit.
WABT validates and decompiles the module; Harmony projects inventory Evidence.
Retain declared effects and stale-exception checks.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
@N0zoM1z0 N0zoM1z0 added the bug Something isn't working label Oct 11, 2026
@morluto
morluto marked this pull request as ready for review October 11, 2026 17:38
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T17:40:21.870975Z d66102c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@N0zoM1z0
N0zoM1z0 merged commit dfe3117 into main Oct 11, 2026
28 checks passed
@N0zoM1z0
N0zoM1z0 deleted the fix/tool-effects-static-wording branch October 11, 2026 17:49
@N0zoM1z0

Copy link
Copy Markdown
Collaborator Author

Reviewed the complete three-line diff against the canonical tool effects and provider implementations. WABT uses validation/disassembly/WAT tools; Harmony projects inventory Evidence. The existing foreign-execution assertions and stale-exception checks remain intact.

Reproduced the sole CI audit failure on main (1 failed / 4 passed); the fix passes all five tests. Normal pre-commit and pre-push checks pass. Exact-head automated and independent review found no remaining blocker.

Exact-head CI on d66102c: all four test shards, coverage/timing and CI required pass (10 successful checks, 18 skipped). Merged with the requested coauthor trailers preserved and both GitHub accounts recognized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant