Repository navigation
fix(test): audit static Wasm and Harmony tool wording - #1917
Conversation
Account for explicit nonexecution wording in the existing tool-effects audit. WABT validates and decompiles the module; Harmony projects inventory Evidence. Retain declared effects and stale-exception checks. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com> Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com> Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Reviewed the complete three-line diff against the canonical tool effects and provider implementations. WABT uses validation/disassembly/WAT tools; Harmony projects inventory Evidence. The existing foreign-execution assertions and stale-exception checks remain intact. Reproduced the sole CI audit failure on main (1 failed / 4 passed); the fix passes all five tests. Normal pre-commit and pre-push checks pass. Exact-head automated and independent review found no remaining blocker. Exact-head CI on |
Summary
The effects-wording audit rejects
inspect_wasm_artifact(“No … WASM execution”) andproject_harmony_application_graph(“execution-free … inventory”). Add their documented nonexecution reasons to the existing manual audit. This fixes the sole test failure in the #1912 CI run.Problem and expected behavior
Execution vocabulary in a negative statement does not declare foreign-code execution. The audit should accept these reviewed static tool descriptions and continue rejecting unaudited execution wording or stale exceptions.
Change and scope
Three lines in the existing test-only exception map. Source review confirms WABT uses validation/disassembly/WAT tools and Harmony projects authenticated inventory Evidence. The canonical effects and audit assertions are retained. CI-audit maintenance is tracked by the linked failed run.
Contract and boundary impact
toolEffects.test.ts.Evidence and regression coverage
Latest main
9d8e42b: one failure, four passing tests, with exactly these two tool names rejected. After the fix, all five effects tests pass, including complete tool inventory, annotation derivation and stale-exception checks.Validation performed
npm run test:local -- src/contracts/toolEffects.test.ts— 1 failed/4 passed before; 5 passed after.d66102c— no remaining blocker. Exact-head CI: ten successful checks, 18 skipped; all four test shards and the required CI check pass.Compatibility, safety, and release
Test-audit scope; no migration, package or release metadata change. No target or provider execution performed for this audit correction.
Review checklist