Skip to content

test(contracts): audit static WASM and Harmony wording - #1918

Closed
N0zoM1z0 wants to merge 1 commit into
mainfrom
fix/tool-effects-negative-wording-1904-20261012
Closed

N0zoM1z0 wants to merge 1 commit into
mainfrom
fix/tool-effects-negative-wording-1904-20261012

Conversation

@N0zoM1z0

Copy link
Copy Markdown
Collaborator

The authority wording guard from #1904 treats “No … WASM execution” and “execution-free” inventory as affirmative target execution. Add these two audited descriptions to its existing explanation table: WABT performs static target inspection, and Harmony projects inventory Evidence.

The failing main-side test was reproduced in a separate worktree: the same two tool names failed before the correction; all five effect tests pass afterward. File lint, formatting and whitespace checks pass. This also resolves the inherited test failure blocking #1913.

Follow-up to #1904.

Account for two descriptions that explicitly disclaim target execution in the existing reasoned wording audit. Their provider effects and foreign-authority checks remain intact.

Refs: #1904
Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T17:42:31.436113Z a35fa82 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@N0zoM1z0

Copy link
Copy Markdown
Collaborator Author

Closing as superseded by the independently merged #1917, which audits the same two static-inspection descriptions. We will use that existing main-side correction for #1913 rather than merge a duplicate. The separate inherited ManagedPe fixture typecheck error is already corrected by 6407718.

@N0zoM1z0 N0zoM1z0 closed this Oct 11, 2026
@morluto morluto added area: tests Test suite and verification area: native Native analysis and decompilation, including Ghidra, IDA, and Hopper analysis behavior labels Oct 14, 2026
@morluto

morluto commented Oct 15, 2026

Copy link
Copy Markdown
Owner

Thanks @N0zoM1z0 for reproducing the static-authority wording false positives for the WASM and Harmony descriptions and narrowing the regression to the explanation table. Main’s contract test now covers those audited descriptions in dfe31172c (main).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: native Native analysis and decompilation, including Ghidra, IDA, and Hopper analysis behavior area: tests Test suite and verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants