Repository navigation
test(signals): verify native decoder discovery coverage - #2818
Merged
Merged
Conversation
Compare catalog and help pages against independent native sigrok output, including full coverage counts, empty matches and boundary offsets. Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Include the upstream formatting and test-function lint corrections before rerunning decoder-discovery verification and protected merge checks. Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Include the upstream formatting and test-function lint corrections before rerunning decoder-discovery verification and protected merge checks. Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
* fix(comparison): preserve incomplete function call evidence Keep missing, unknown, partial and unresolved call relationships unknown in function comparisons and reconstruction claims. Aggregate IDA caller and callee coverage without overwriting uncertainty. Validate with 144 focused tests, typecheck/lint, docs checks and test discovery. Real providers were not verified; the full headless IDA session suite requires unavailable Windows native controls. * fix(comparison): recheck historical calls-only changes --------- Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
Preserve the maintainer formatting fix and current-main synchronization while retaining the native signal discovery verifier. Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Validate signal discovery coverage against the latest reconstruction fixture baseline. Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
…pr-refresh-2818-20261014
Unify the tested head with the maintainer branch after both incorporated the same current main revision. Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Revalidate the signal discovery verifier against the current integration baseline. Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Carry the verified signal discovery change over the latest unrelated application fixes. Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Validate the signal discovery verifier on the settled integration head. Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Include the latest unrelated package-verifier ownership fix before qualification. Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Include the latest unrelated Wasm and installation-documentation updates before the final CI run. Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Include the latest unrelated process-deadline and ZIP-coverage fixes before local qualification. Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The real sigrok verifier previously checked only that UART appeared in a catalog search. CLI/MCP agreement could therefore pass when both adapters returned the same incomplete catalog or incorrect coverage counts.
Compare the installed native catalog and UART help independently with every returned page and all coverage fields. Exercise default and unlimited pages, offsets at/past the end, mixed-case queries, literal special characters, and empty matches. This follows up #2487; production behavior is unchanged.
Validation on Linux x64 with sigrok-cli 0.7.2 / libsigrokdecode 0.5.3, using 2 CPUs and an 8 GiB process-family limit:
o200k_base, not billed usage; model reasoning excluded). Median wall time is 1.286 vs 1.367 seconds, CPU 0.92 vs 0.90 seconds, and sampled peak server/native process-family RSS 435 vs 434 MiB. Page cache is uncontrolled and the sampler adds overhead; no speedup or caching claim. The complete hardware/benchmark run peaked at 876 MiB.npm run check:ci: 8/8 static tasks and architecture guards passed on the previously synchronizedmain; peak family RSS 4.13 GiB. On the final current-base head, it reaches the formatter and fails only in two unchangedmainfiles (enhancedTools.04-uses-complete-inventories-inline.test.tsandpackagePlatformDiagnostics.test.ts); both are byte-identical toorigin/main. The run peaked at 2.60 GiB.git diff --checkpasses.The validated revision is
6ab5a82d95f5eac85d2630d3c2035a395d921d4a. Windows/macOS sigrok behavior is not claimed; this provider is explicitly Linux-only.