Skip to content

fix(ci): restore reconstruction and formatting checks - #2853

Closed
N0zoM1z0 wants to merge 15 commits into
mainfrom
fix/main-format-baseline-20261013
Closed

N0zoM1z0 wants to merge 15 commits into
mainfrom
fix/main-format-baseline-20261013

Conversation

@N0zoM1z0

@N0zoM1z0 N0zoM1z0 commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Current main still fails one portable reconstruction test and its pinned formatter after the independently merged #2895 and #2910 repairs. This keeps only the remaining three-file baseline repair:

Validation on the pinned Node.js 24.18.0 / npm 11.16.0 toolchain with 2 CPUs and an 8 GiB process-family limit:

  • npm run check:ci: 8/8 static tasks and architecture guards passed on current main; peak family RSS 5.67 GiB.
  • npm run test:local -- src/domain/reconstructionVerification.functionSources.test.ts: 68/68 passed; peak family RSS 482 MiB.
  • git diff --check passed.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low impact] The reviewed changes appear safe to merge.

Summary

This PR fixes the reconstruction fixture and formatter layout.

  • Reconstruction checks now use a dossier fixture with all facets declared.
  • The Turkish support table and Hopper check match the formatter's layout.

The commits have different merge bases with the target, so the full PR diff was reviewed. No previous review threads were supplied. GitHub authentication was unavailable, so whether another PR supersedes this one could not be checked. Tests were not run during this review.

Reviews (5) · Last reviewed commit: "style: format current main additions" · Reviewed by Greptile

Apply the pinned formatter layout to the two files that currently fail the static formatting gate.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
@N0zoM1z0
N0zoM1z0 force-pushed the fix/main-format-baseline-20261013 branch from e9877ed to ce8005e Compare October 13, 2026 14:49
@N0zoM1z0 N0zoM1z0 changed the title style: restore the main formatting baseline chore: restore the main formatting baseline Oct 13, 2026
N0zoM1z0 and others added 9 commits October 13, 2026 15:43
Validate the formatting and reconstruction assertion repairs against the
latest merged feature and correctness changes.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Keep the reconstruction fixture consistent with its complete relationship coverage so empty call sets establish observed absence after the facet-availability contract landed.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Validate the formatting and reconstruction fixture repairs against the
latest merged feature and correctness changes.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Validate the formatting and reconstruction fixture repairs against the
latest merged feature and correctness changes.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Share the node:fs/promises import and keep a single node:path join binding so the merged inventory tests compile under the static gate.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Validate the formatting and reconstruction fixture repairs against the
latest merged feature and correctness changes.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Mark the client-directory cases as a readonly tuple so strict indexed access keeps each filesystem path defined.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Validate the formatting and reconstruction fixture repairs against the
latest merged feature and correctness changes.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Keep Devin on its implemented JSON registration dialect; the DSH_HOME fix accidentally selected an unsupported format name.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
@N0zoM1z0 N0zoM1z0 changed the title chore: restore the main formatting baseline fix(ci): restore the main CI baseline Oct 13, 2026
N0zoM1z0 and others added 3 commits October 13, 2026 16:00
Validate the baseline repairs against the latest JavaScript and CLI fixes.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Escape DEX class-name delimiters in the owning schema so advertised patterns compile under JavaScript Unicode Sets. Keep the clean-runtime fixture preflight independent of unrelated same-user processes; the fixture inode is freshly copied and the post-launch assertion still exercises exact executable identity.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Validate the baseline repairs against the latest JavaScript semantic fix.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
zhangguiping-xydt added a commit to zhangguiping-xydt/rea that referenced this pull request Oct 13, 2026
Reuse the complete-facet fixture correction proposed in morluto#2853. This keeps the historical call-coverage assertions valid after facet availability became explicit. Apply the pinned formatter to the process inventory code merged in morluto#2910. No assertions or CI gates are removed.
N0zoM1z0 and others added 2 commits October 13, 2026 17:28
Accept the independently merged baseline fixes and retain only the reconstruction fixture coverage still missing from main.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>

# Conflicts:
#	tests/boundary/mcp/ghidraInventoryMcp.test.ts
#	tests/process-global/cleanLinuxHopperRuntime.test.ts
Apply the pinned formatter to the newly merged Turkish capability table and isolated Linux Hopper inventory helper.

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
@N0zoM1z0 N0zoM1z0 changed the title fix(ci): restore the main CI baseline fix(ci): restore reconstruction and formatting checks Oct 13, 2026
morluto pushed a commit to zhangguiping-xydt/rea that referenced this pull request Oct 13, 2026
Reuse the complete-facet fixture correction proposed in morluto#2853. This keeps the historical call-coverage assertions valid after facet availability became explicit. Apply the pinned formatter to the process inventory code merged in morluto#2910. No assertions or CI gates are removed.
morluto pushed a commit to zhangguiping-xydt/rea that referenced this pull request Oct 13, 2026
Reuse the complete-facet fixture correction proposed in morluto#2853. This keeps the historical call-coverage assertions valid after facet availability became explicit. Apply the pinned formatter to the process inventory code merged in morluto#2910. No assertions or CI gates are removed.
morluto pushed a commit to zhangguiping-xydt/rea that referenced this pull request Oct 13, 2026
Reuse the complete-facet fixture correction proposed in morluto#2853. This keeps the historical call-coverage assertions valid after facet availability became explicit. Apply the pinned formatter to the process inventory code merged in morluto#2910. No assertions or CI gates are removed.
morluto pushed a commit to zhangguiping-xydt/rea that referenced this pull request Oct 13, 2026
Reuse the complete-facet fixture correction proposed in morluto#2853. This keeps the historical call-coverage assertions valid after facet availability became explicit. Apply the pinned formatter to the process inventory code merged in morluto#2910. No assertions or CI gates are removed.
@N0zoM1z0

Copy link
Copy Markdown
Collaborator Author

Closing as superseded by #2938 and #2964. Latest main now contains the exact two formatter repairs and the complete reconstruction fixture facets; merging it into this branch leaves an empty diff.

Before supersession, the focused reconstruction suite passed 68/68 and npm run check:ci passed all eight static tasks plus the architecture guards under the documented 2-CPU / 8-GiB limit.

@N0zoM1z0 N0zoM1z0 closed this Oct 13, 2026
@morluto morluto added bug Something isn't working area: evidence Evidence, artifacts, and reconstruction labels Oct 14, 2026
@morluto

morluto commented Oct 15, 2026

Copy link
Copy Markdown
Owner

Thanks, @N0zoM1z0, for narrowing the broken static checks to the Turkish README formatting and missing reconstruction fixture facets. Main now has the formatter repair and complete fixture coverage across the follow-up fixes (main).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: evidence Evidence, artifacts, and reconstruction bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants