Repository navigation
test(browser): cover DOM relation whitespace and empty values - #2845
zhangguiping-xydt wants to merge 7 commits into
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
[Low impact] The test-only changes appear safe to merge. SummaryAdds regression coverage in
The supplied diff changes one test file, not the two stated in the PR description. No runtime code, dependencies or permissions change. No actionable correctness, security or repository-rule issues were found. Review checks were source-based; no tests or browser workflows were run during this review. Reviews (12) · Last reviewed commit: "test(browser): merge main and preserve D..." · Reviewed by Greptile |
09c84a4 to
e61d241
Compare
e61d241 to
158dc95
Compare
Own service-worker CDP registrations and retry failed teardown. Admit redaction and network metadata against remaining capture capacity, retain explicit omission reasons, and preserve source URL, redirect ancestry, caller-selected content, and historical capture values. Forward CLI cancellation through provider cleanup. Reviewed fixes: #2263, #2637, #2767, #2845, #2859, #2863, #2872, #2874, #2876, #2879, #2955, #2957, #2961, #3033. Validation: 25 current event/network source tests passed; earlier focused browser lanes passed 201 source tests and 176 boundary tests with two skips, plus 35 Python tests. Real browser/Windows lanes were not rerun. Playwright allocation before admission remains unbounded by these retention limits.
|
@codex review |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
TL;DR: This test-only PR passes. Its two test files give 91 passing tests on Node 22, 24 and 26, up from 74 before the PR. They also pass when merged onto current main. Thanks, zhangguiping-xydt, for all of the new tests in it. I tested head a437d87. Its merge base is 29d3dcb, and main was at 40f73f6 (#3735). Results
Not run
Commandsgit -C ~/code/rea-mirror/rea.git fetch origin
git -C ~/code/rea-mirror/rea.git archive a437d872df3b20b3843682cc3a4fcba35cf033c3 | tar -x -C /tmp/fresh-1015/2845-head
npm ci && npm run build && npm run test:prepare # Node 24.18.0, all exit 0
node scripts/run-development-tests.mjs focused \
src/browser/CdpCaptureDocuments.baseUrl.test.ts \
src/browser/CdpCaptureDocuments.test.ts
# head: exit 0 on Node 22, 24 and 26 (91 passed)
# base test files in the head tree: exit 0 (74 passed)
git merge-file main.copy base.copy pr.copy # for each of the two test files, exit 0
# fresh main tree (40f73f62b), as is: exit 0 (76 passed); with the merged test files: exit 0 (91 passed)Test setup🤖 Generated with Claude Code (Sonnet 5.5, verified by Opus 5.5) 🦊 |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Closing as superseded by f690571 and the current DOM capture tests. Main covers HTML relation-token whitespace, CDP’s empty-value sentinel at the decoder boundary, empty form destinations, SVG href precedence, and namespace restoration. Both current DOM source suites passed locally (36 tests). |
Summary
Refs #2840. Add regression coverage for HTML relation-token whitespace and CDP empty-value encoding. Non-HTML whitespace must not invent agent hints; valid empty values must preserve links, form destinations, SVG empty-href precedence, and XML namespace undeclarations.
Approach and conflict resolution
Merged upstream main
72d5e72e6d7b7997c4ecb11972fc405be8ec67d2while preserving the PR history. Kept both the PR's relation-token tests and upstream's prefixed XHTML form tests at the conflicting insertion point, together with upstream namespace/import changes. Main already contains the negative-index cases and the canonical production decoder. The resulting diff against main changes onlysrc/browser/CdpCaptureDocuments.baseUrl.test.ts; production code and dependencies are unchanged.Validation
Current head:
b91b450c1799021fcf27a97368cdb8522028f283. Linux, pinned Node.js 24.22.1/npm 11.16.0.npm run check:fast: passed (typecheck and lint, reusing the successful outputs for the identical source tree).npm run lint:typed -- src/browser/CdpCaptureDocuments.baseUrl.test.ts: passed, 0 errors / 0 warnings.npm run check: typecheck, lint/module boundaries, formatting, Knip, metadata, architecture guards, and production reachability completed successfully. Its final full-repository typed-lint stage was killed by the 6 GiB container memory limit (confirmed by the kernel OOM log); a complete localcheckpass is not claimed.The host's older glibc cannot load main's native TypeScript checker; static checks ran in offline Debian bookworm containers with the same pinned Node/npm toolchain. Source tests ran directly on the host. Full-repository typed lint remains unverified locally after the resource-limited attempt; the changed-file typed check passed separately.
Historical evidence on
a437d872df3b20b3843682cc3a4fcba35cf033c3: built CLI and stdio MCP with an owned localhost page and real Chrome 138 passed the DOM/form assertions and matched ChromerelList/DOM-property oracles. Prior CI run 38528268551 passed. These are prior-head results; real Chrome CLI/MCP workflows were not rerun for this test-only conflict repair. The earlier complete browser suite failed later storage seeding on Chrome 138, so no complete browser pass or other-OS verification is claimed.Author readiness
Human owner: @zhangguiping-xydt