Repository navigation
fix(web-capture): bound the mitmproxy headline facet index - #2876
Conversation
…previews Capture previews selected HAR/SAZ headline names (url, status) only, so a native mitmproxy record lost its request target (scheme, host, port, authority, path) and its status_code while keeping the reason phrase, and the matching numeric sidecars were filtered out. Select those mitmproxy headline fields too; headers and payloads stay omitted.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
[Medium impact] The PR appears safe to merge; no blocking issue was found. SummaryBounds the per-record facet index used for mitmproxy headlines without changing which fields qualify.
No actionable issues found. The earlier, unnumbered Review used the full PR changes because the previous review and current head have different merge bases with the supplied target commit. Runtime checks were not run. Live supersession status could not be checked because GitHub authentication was unavailable. Diagram%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Record facets] --> B{Headline coordinate or ancestor?}
B -->|Yes| C[Keep at most two per group]
B -->|No| D[Do not retain facet]
A --> E[Check seven fixed descendant prefixes]
C --> F[Existing headline checks]
E --> F
F --> G[Same preview choices]
Reviews (34) · Last reviewed commit: "test(web-capture): count long set additi..." · Reviewed by Greptile |
* fix(comparison): preserve incomplete function call evidence Keep missing, unknown, partial and unresolved call relationships unknown in function comparisons and reconstruction claims. Aggregate IDA caller and callee coverage without overwriting uncertainty. Validate with 144 focused tests, typecheck/lint, docs checks and test discovery. Real providers were not verified; the full headless IDA session suite requires unavailable Windows native controls. * fix(comparison): recheck historical calls-only changes --------- Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dfb36b5655
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Select the mitmproxy target and status fields only for mitmproxy records, only when they are scalars, and the path only in origin form. An absolute, network-path or otherwise ambiguous path spelling can carry userinfo that the native bridge's redaction does not recognise, and a nested value could copy an arbitrary record subtree into the preview; both stay in complete record pages. Other formats keep their existing headline fields.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0ab028759
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…rom previews Origin-form checks alone accepted slash-backslash and slash-control spellings such as /\user:password@host/a, which WHATWG resolves as an authority with credentials and the recorded transport-URL interpretation already treats as ambiguous credentials. Preview a mitmproxy path only when parseRecordedTransportUrl finds no credentials, and omit mitmproxy headline strings longer than 8 KiB so one record cannot exceed the reply budget; both stay in complete record pages.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6fa5bbe84
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…f previews Native redaction covers only request path and authority, so a malformed state such as host "user:password@example.test" passed through the preview. Omit every non-path mitmproxy headline string that contains a userinfo marker (@); valid schemes, hosts and ports never do, and the value stays in complete record pages.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 81b10c30f9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
TL;DR: The fix works on a real mitmproxy capture. Without it, the preview drops the request path and the status code. With it, both show, and headers and bodies stay out. Edit: I retested a newer head, 77b4933. The new results are here. All six items in the Not run list below are still not run, so none is struck through. The new comment also says why the real mitmdump capture could not be rerun. I tested 81b10c3 against base 2895a18 (#2943). The head moved twice while I tested, so I also ran a8df0da and e6fa5bb (see the first fold). Results
Old source means the file from 2895a18. The six failures are the headline test, the OPTIONS test and the four new userinfo tests. The seven "keeps ... out" tests pass on the old code too, because it adds no fields. The three older tests pass as well. Real capture: mitmdump 12.2.3 (MIT) as a reverse proxy on loopback, six requests, status 200, 404 and 501, Node 24.18.0.
Two credential cases came up in review: an odd path and a host value. Both are withheld on 81b10c3. I checked them with a real request and with a flow I built with the mitmproxy library. The credentials fold has the details. Not run
Thanks, Dragolone, for the fix and for the quick follow-ups on the review notes. Results on two earlier heads
More checks on credentials and the fixture script
Commandsnode scripts/run-development-tests.mjs focused src/domain/analysisView/webNetworkCaptureView.test.ts
REA_MITMDUMP_COMMAND=/tmp/pr2876/venv/bin/mitmdump node scripts/rea.mjs inspect-web-network-capture /tmp/pr2876/flows.mitm mitmproxy --json
jq -c '{source: {kind: "inline", evidence: .}, view: {kind: "capture", detail: "preview", offset: 0, limit: 6}}' capture.json > view.json
node scripts/rea.mjs inspect-analysis-view view.json --json
Test setup
🤖 Generated with Claude Code (Sonnet 5.5, verified by Opus 5.5) 🦊 |
…formed shapes A per-string length cap still let a malformed capture fill every target slot with escape-heavy text, so one default preview page could expand to about 18 MiB of JSON. Preview each mitmproxy field only in its own shape: a short scheme token, host/authority without controls, whitespace or userinfo markers, integer port and status code, and a path of at most 2 KiB without control characters. That bounds every record's headline to about 4 KiB serialized, even for an escape-heavy path.
|
Thanks @CassieFox23 — the real mitmdump capture across Node 22/24/26 is great confirmation. On the 8,001-character path you noted: 5149edf now admits each mitmproxy field only in its well-formed shape, including a path of at most 2 KiB without control characters, so that case is withheld from the preview as well (it stays on complete pages). |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5149edfac7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…integer type Select mitmproxy target fields only from the request and status_code only from the response, so an unknown scalar extension such as response.path or request.status_code is not promoted to a headline. Admit port and status_code only when the record's numeric sidecar reports the producer's integer type; a native float such as 443.0 is otherwise indistinguishable from 443 after JSON parsing.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f069727642
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
… numeric headlines An inline parent could pair request.port 443 with an integer sidecar whose literal is unbounded or does not represent the value, or with duplicate sidecars, and the selected-pointer filter would copy them into the preview. Admit port and status_code only with exactly one integer sidecar whose literal is the value's canonical decimal, which also bounds the copied literal to a few characters.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8bc0b745ae
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The mitmproxy container format does not make every retained flow HTTP; the bridge keeps non-HTTP and unknown flow states with their extensions. Add the mitmproxy target and status candidates only when the record's own type is "http".
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
# Conflicts: # src/domain/analysisView/webNetworkCaptureView.test.ts # src/domain/analysisView/webNetworkCaptureView.ts
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
TL;DR: On head 77b4933, the PR's test file passes on Node 22, 24 and 26 (52 tests). The 8,001-character path I flagged is now withheld, and so are values just past the field limits. Main already holds those limits. This PR adds a smaller facet index. Without it, the test file runs out of memory on Node 26. Edit: I tested the open review threads on this same head. Results are here. I retested head 77b4933. The base was 7375ab6. My last results were on 81b10c3 (see my earlier comment). The PR is now small: source +49/-35 and test +26 on top of main. Results
The crash is on Node 26. With the base source, the two "million-character facet pointer" tests fail. They fail with "JavaScript heap out of memory" at about 4 GB. I ran it twice, then again on those two tests alone. Node 22 and 24 pass them on the base source. I do not know why Node 26 differs. Field limits, shown with a test I wrote. The test builds one mitmproxy record and checks what reaches the preview. I ran it on Node 24. Head is the same on Node 22 and 26:
So the 8,001-character path is gone on both base and head. The 2 KiB path limit and the other shape rules already sit on main. This PR changes none of these rows compared with base. Not run
Thanks, Dragolone, for the quick fixes and for the plain answer on the 8,001-character path. Commandsnpm ci && npm run prepare && npm run build:cached
node scripts/run-development-tests.mjs focused src/domain/analysisView/webNetworkCaptureView.test.ts
node scripts/run-development-tests.mjs focused src/domain/analysisView/edgeProbe.test.ts
node scripts/run-development-tests.mjs focused tests/boundary/browser/historicalWebCapture.test.ts tests/boundary/browser/historicalCaptureDecoder.test.ts
git show 7375ab6e3:src/domain/analysisView/webNetworkCaptureView.ts > src/domain/analysisView/webNetworkCaptureView.ts
node node_modules/vitest/vitest.mjs run src/domain/analysisView/webNetworkCaptureView.test.ts -t "million" --pool=forks
node scripts/rea.mjs inspect-web-network-capture flows-reverse-real.mitm mitmproxy --json
Test setup🤖 Generated with Claude Code (Sonnet 5.5, verified by Opus 5.5) 🦊 |
|
TL;DR: Same head as my last comment, 77b4933. 29 of the 30 open Codex threads describe a problem that does not reproduce on it. The 30th asks to move the work into the bridge. I did not test that. The PR's own change holds. The old code crashes Node 26 on a large probe, and the new code does not. Edit (2 Nov): I retested this PR on its new head, a049415. Results are here. I tested head 77b4933 again, this time against every open review thread. All 30 open threads are from Codex and all are marked outdated. Outdated only means the line moved, so I fed each thread's input to the current code. The base was 7375ab6. Main has moved to 92dadf9. Its copy of this file differs from the base only in imports and one message, so main still has the old index function. VerdictsEvery row's input was a fixture I wrote. "Not real" means the bad input is kept out of the preview. A control record in the same run does get its headline fields, so the checks are not empty.
The nested-object thread in the size row also asks for the redesign in the last row. I tested only its example. The same 22 checks also pass on the old file (7375ab6, Node 24). So the first eight rows were already fine before this PR. Only the facet-index cost row is about what this PR changes. Results by Node
The timings are one run each on a shared box, so treat them as rough. I did not measure memory in a way I trust, and the memory use of the whole test run was similar on Node 22 and 24. Not run
Thanks, Dragolone, for the work on the facet index. In 6,000 random records, the preview matched the old file's exactly. Test setupCommands
🤖 Generated with Claude Code (Sonnet 5.5, verified by Opus 5.5) 🦊 |
|
Thank you @CassieFox23, this is very useful. The Node 26 heap exhaustion on the base file is a stronger signal than my Node 24 benchmark, which only showed the slowdown. I've updated the PR description's evidence section to cite your results, including the 6,000-record equivalence check. Following your thread-by-thread retest, I'm resolving the Codex threads you found do not reproduce on 77b4933. I'm leaving the two threads that ask to move headline normalization into the mitmproxy bridge open, since that is a design decision for the maintainers. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merged latest Why
Validation (local macOS, merged head)
|
|
Thanks, Dragolone. I checked the thread list on GitHub, and the resolved set matches my retest. Of the 30 threads I tested, 28 are resolved and 2 are open: the producer boundary thread and the nested object thread. The nested object example did not reproduce, but that thread also asks for the bridge change, so it stays open. Both are for the maintainers. 🤖 Written with Claude Code (Sonnet 5.5, verified by Opus 5.5), posted with my OK 🦊 |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Thanks for isolating the facet-index follow-up. The headline projection has landed, but current main still expands ancestors and indexes record facets here. This remains a distinct resource-bound proposal; please retain the existing omission/uncertainty behavior and representative boundary controls while updating it. |
…related facets The bounded facet index must not change what a mitmproxy preview withholds or keeps. Beside 20,000 unrelated sidecars, a redacted host and a path with a facet beneath it stay withheld while the scheme, port and status remain, with only their own sidecars retained. The test passes against both the current main projection and this change.
|
Thanks @morluto. I've updated the branch to current main (6a226bd) in a049415. The merge was clean: main's recent changes to this file ( Omission and uncertainty behavior is retained:
Validation on Node 24.22.1: |
There was a problem hiding this comment.
TL;DR: Head a049415 passes all 54 tests in the PR's test file on Node 22, 24 and 26. The source change is the same one I tested on 77b4933, and the one new commit only adds a test. The bound works. On Node 26 the old index runs out of memory on the PR's two tests with huge pointers. The new code takes a few ms.
Edit (5 Nov): Dragolone took the nit in 67c3550. The two big pointer tests now count the long strings the preview adds to sets, and expect none. That should catch the old index on every Node, not only by a crash on Node 26. I read the change and the index code it checks. I didn't run it.
I retested head a049415. The base was 6a226bd. Main is now 2d11fd9. It still has the old index (addAncestors and groupByPointer), as morluto said on 26 Oct. The PR's change applies to main's file with only line offsets. Below, "old file" means the base's copy of webNetworkCaptureView.ts. Its index code is identical to main's.
Results
| Check | Node 22.23.4 | Node 24.22.1 | Node 26.12.1 |
|---|---|---|---|
| PR test file at head, 54 tests | pass | pass | pass |
| My 22 earlier checks at head | pass | pass | pass |
| 6,000 random records, old file against head | no differences | no differences | no differences |
| PR's two million-character pointer tests, on the old file | pass, 330 and 181 ms | pass, 291 and 145 ms | out of memory, each test alone |
| Same two tests at head | 6 and 5 ms | 5 and 4 ms | 20 and 5 ms |
| 200,000 sidecars plus a 1,000,000-character pointer, old file | 507 ms | 393 ms | out of memory |
| Same input at head | 84 ms | 69 ms | 96 ms |
The timings are single runs in a VM, so treat them as rough. The test file had 52 tests last time. It has 54 now: one came from main, and one is the new control.
Findings
Should fix: nothing.
Nit
- The two million-character tests have no time or size limit. On Node 22 and 24 they pass on the old index too, so only Node 26 catches a regression, and it does so by crashing. A timing or heap check would catch it on every Node. Timing checks can be flaky, so this is optional.
Looks good
- The source change is the same as at 77b4933. All four heads I compared have the same patch id (d90ccc99e8), each against its own base. The new commit a049415 adds 50 test lines and nothing else.
- The bound holds for long and deep pointers. In my own timing test, 2,000 facets with 500-level pointers took 16 to 25 ms at head and 854 to 1,056 ms on the old file (Node 22, 24 and 26). For 200,000 facets with short pointers, head took 715 to 771 ms and the old file 804 to 844 ms. That is about the same. I timed the whole preview call, so I can't say how much of it is the index.
- The new control test does its job. It passes on the old index too, as the PR says, so it pins what is withheld and kept, not the bound. In a scratch copy with container marking switched off, 5 tests fail, the control among them. With redactions left out of the index, 6 fail, the control among them.
- The two threads that were open on 21 Oct are still the only ones open: the producer boundary and the nested object. Both are design asks for the maintainers. I did not retest them.
Not run
- The MCP tool and its response budget. I ran the preview function only.
- The mitmproxy bridge. I did not read or run it.
- A real mitmdump capture. It is not installed.
- qlog records.
- Moving the work into the bridge.
- Main's current tree. Its file needs two files this PR's tree lacks. So I used the base's file, which has the same index code. I also checked that the PR applies to main's file.
test:fast,test:built, the full suite, type check and lint. CI already passed them on this head.- A clean memory figure that leaves out the test fixture.
- macOS and Windows.
Test setup
- Box: Fedora 44 VM (4 vCPUs, 8 GB) on my Nobara 44 machine, guest kernel 7.2.11
- Node: 22.23.4, 24.22.1, 26.12.1
- Head / base: a049415 / 6a226bd (main was 9bea563 at the start and 2d11fd9 at the end; neither touches the PR's two files)
- Other: rea-agents 6.8.0, g++ 16.2.1. The timings are single runs, and I did not check whether other jobs shared the VM.
Commands
npm --prefix <tree> ci --offline (Node 24, tree at a04941520)
npm --prefix <tree> run test:prepare (Node 24)
npm --prefix <tree> run test:focused -- src/domain/analysisView/webNetworkCaptureView.test.ts (Node 22, 24, 26)
node node_modules/vitest/vitest.mjs run src/domain/analysisView/webNetworkCaptureView.test.ts --reporter=verbose (old file in a copy: Node 22, 24, 26; head: Node 22, 24)
node node_modules/vitest/vitest.mjs run <same file> -t million-character --pool=forks (old file Node 26; head Node 26)
node node_modules/vitest/vitest.mjs run src/domain/analysisView/probe2876.test.ts --pool=forks (my earlier probe file, head: Node 22, 24, 26)
PROBE_IMPL=base ... probe2876.test.ts -t scale --pool=forks (old file: Node 22, 24, 26)
- The old file is the base's webNetworkCaptureView.ts (6a226bd) copied into a hard-linked copy of the tree, next to the PR's test file.
- The timing test and the two broken copies are my own files in the guest tree. They are not PR code. The timing test is the PR's test file plus two tests that call its
nativePreviewhelper with many facets. - The test files do not mention doctor; I checked with grep first.
🤖 Written and tested with Claude Code (Sonnet 5.5, verified by Opus 5.5), posted with my OK 🦊
…ew-mitmproxy-headline
…pointer tests The two million-character pointer tests had no time or size bound, so on Node 22 and 24 they passed against the old ancestor index too, and only Node 26 caught a regression by running out of memory. Count the strings longer than 1,000 characters the preview adds to sets instead: only the pointer and strings cut from it are that long, the old index added 999,000 and 499,507 of them, and the new index adds none.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Thanks @CassieFox23 for the retest. I took the nit in 67c3550. The two million-character tests now count the strings longer than 1,000 characters that the preview call adds to any
So a regression now fails on every Node version instead of only crashing on Node 26. I ran this on Node 24.22.1 only. b4b9962 merges current main (47cedcc) cleanly. That brings in #7832 and #8061, which both touched this file. Main still has On the merged tree:
|
|
Hey @Dragolone, thanks for this! The fix looks good. What's left: there are 2 unresolved review threads from Codex, all on outdated lines, so if they're already addressed, resolving them should be all that's needed. Happy to get this in once that's sorted out. |
|
Thanks @morluto, both Codex threads are resolved now.
The branch still merges into current main without conflicts, and CI is green. |
Summary
The mitmproxy headline preview from the earlier revisions of this PR landed on main in f690571. This PR now carries only the two follow-up review fixes that came after that revision. Both bound the per-record facet index that
webNetworkCaptureView.tsbuilds for mitmproxy HTTP records.As landed on main,
indexFacetshas two problems:containers.pointerSchemaputs no length or depth bound on facet pointers, so a single 1,000,000-character pointer such as"/".repeat(1_000_000)produces a million set entries.scalars. The mitmproxy bridge emits one sidecar per number, so a record with a large integer array under an unrelated extension allocates an entry for each element. Only/type, the six target/status coordinates and their ancestors are ever queried.Problem and expected behavior
Expected: the index size depends neither on how many facets a record has nor on how long or deep their pointers are, and every headline decision is unchanged.
Change and scope
indexFacetsnow keeps a facet only when its pointer is a headline coordinate or one of their ancestors:"",/type,/request,/responseand the six target/status fields. It keeps at most two facets per pointer, because a second facet already fails every representation check.Every other facet only marks the headline coordinates it lies beneath. It does this with
startsWithagainst seven fixed"<coordinate>/"prefixes, so no strings are derived from its pointer.Not included: moving headline normalization into the mitmproxy producer. That would interpret native state in the bridge and add a field to the shared record schema; it is under discussion in the review thread.
Contribution scope: a resource-bound fix in existing code; a maintainer scope decision is not applicable.
Contract and boundary impact
indexFacetsinsrc/domain/analysisView/webNetworkCaptureView.ts.docs/public/product-catalog.json), package, or installation impact: none.Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
Evidence and regression coverage
src/domain/analysisView/webNetworkCaptureView.test.ts. The new tests are "indexes an unrelated / a path-descendant million-character facet pointer by its headline prefix only". They check that a 1,000,000-character pointer is still classified correctly: unrelated, or beneath/request/path. They also count the strings longer than 1,000 characters that the preview call adds to anySetand expect none. Only the pointer and strings cut from it are that long, so the count stands in for the index size without timing or heap checks. "keeps headline omissions and controls beside many unrelated facets" places 20,000 unrelated sidecars beside a redacted host and a path with a facet beneath it: both stay withheld, while the scheme, port and status remain with only their own sidecars. It passes against both the current main projection and this change, so it pins the omission/uncertainty behavior rather than the bound.webNetworkCaptureView.ts(47cedcc) the two million-character tests fail on Node 24.22.1: the old index adds 999,000 and 499,507 such strings (expected 999000 to be +0,expected 499507 to be +0). With this change it adds none.For evidence-bearing changes:
Validation performed
npx vitest run src/domain/analysisView/ src/browser/history/on this branch merged with main 47cedcc (Node 24.22.1) — 76 files, 1,733 tests passed.npx vitest run src/domain/analysisView/webNetworkCaptureView.test.ts— 55 passed. WithwebNetworkCaptureView.tsreplaced by main's, the two million-character tests fail as shown above, and the boundary-control test passes.npx tsc --noEmit— 0 errors.npx oxlinton the changed files — 0 errors. The three warnings onwebNetworkCaptureView.ts(max-lines,max-params,max-lines-per-function) are also present on main's file.npx oxfmt --checkon the changed files — clean.npm run verify:module-boundaries— passed.npm run check:fast(typecheck, lint) — passed.node scripts/check-doc-facts.mjsafternpm run compile— passed.Compatibility, safety, and release
inspect_analysis_viewpath for admitted mitmproxy Evidence.Author readiness
Human owner: @Dragolone
Before merge
type(scope): outcome.