Repository navigation
fix(ci): skip portable report merge when shards are skipped - #2943
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b669fbc562
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
b669fbc to
6688ad8
Compare
The portable consumer can still run after an upstream build failure, even though the test-shard matrix is skipped and no Vitest blob artifacts exist. Guard artifact download and both report merge variants on successful shards; retain the required-shard gate so skipped or failed shards remain failures. This applies the report-consumer condition from ee0256c to current pinned main without changing action pins or required gates.
6688ad8 to
1f727ff
Compare
When a Build package failure prevents the test-shard matrix from running, the Portable tests job must skip report download and merge because no shard artifacts exist. Failed shards are different: their
!cancelled()upload step can publish blob reports, and merging those preserves partial diagnostics. Permit report download and both full/fast merges for successful or failed shard results; keep them skipped when shards are cancelled or skipped. The final required-shard gate still fails every required outcome other than success, and successful timing history remains success-only.Also correct
CONTRIBUTING.mdto describe routine CI as required checks passing for the current PR revision, without requiring every PR to stay up to date withmain. Administrators retain the documented recovery override.Validation: focused
ciTestReports.test.ts(7 tests),npm run check:fast,npm run docs:check, pinned actionlint v1.7.7, andgit diff --checkpassed. Hosted CI has not yet completed for this revision.