Skip to content

fix(ci): skip portable report merge when shards are skipped - #2943

Merged
morluto merged 3 commits into
mainfrom
codex/ci-skip-portable-merge-after-skipped-shards
Oct 13, 2026
Merged

morluto merged 3 commits into
mainfrom
codex/ci-skip-portable-merge-after-skipped-shards

Conversation

@morluto

@morluto morluto commented Oct 13, 2026 •

Copy link
Copy Markdown
Owner

When a Build package failure prevents the test-shard matrix from running, the Portable tests job must skip report download and merge because no shard artifacts exist. Failed shards are different: their !cancelled() upload step can publish blob reports, and merging those preserves partial diagnostics. Permit report download and both full/fast merges for successful or failed shard results; keep them skipped when shards are cancelled or skipped. The final required-shard gate still fails every required outcome other than success, and successful timing history remains success-only.

Also correct CONTRIBUTING.md to describe routine CI as required checks passing for the current PR revision, without requiring every PR to stay up to date with main. Administrators retain the documented recovery override.

Validation: focused ciTestReports.test.ts (7 tests), npm run check:fast, npm run docs:check, pinned actionlint v1.7.7, and git diff --check passed. Hosted CI has not yet completed for this revision.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T18:27:34.555439Z 1f727ff New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b669fbc562

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml Resolved
@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[High impact] The PR appears safe to merge; report merging does not weaken the required-shard check.

Summary

The PR skips portable report download and merging when shards are skipped or cancelled. It keeps partial diagnostics available when shards fail.

  • Portable tests skip report merging when no shard reports exist.
  • Routine merge guidance focuses on checks for the current PR revision.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Shard result] --> B{Success or failure?}
  B -->|Yes, and not cancelled| C[Download and merge available reports]
  B -->|Skipped or cancelled| D[Skip download and merge]
  C --> E[Keep available diagnostics]
  E --> F{Required shards succeeded?}
  D --> F
  F -->|No| G[Fail required check]
  F -->|Yes| H[Pass shard gate]
  H --> I[Publish timing history only after a successful full run]
Loading

Reviews (3) · Last reviewed commit: "docs: clarify current revision CI policy" · Reviewed by Greptile

Comment thread .github/workflows/ci.yml Resolved
@morluto
morluto force-pushed the codex/ci-skip-portable-merge-after-skipped-shards branch from b669fbc to 6688ad8 Compare October 13, 2026 18:03
The portable consumer can still run after an upstream build failure, even though the test-shard matrix is skipped and no Vitest blob artifacts exist. Guard artifact download and both report merge variants on successful shards; retain the required-shard gate so skipped or failed shards remain failures.

This applies the report-consumer condition from ee0256c to current pinned main without changing action pins or required gates.
@morluto
morluto force-pushed the codex/ci-skip-portable-merge-after-skipped-shards branch from 6688ad8 to 1f727ff Compare October 13, 2026 18:25
@morluto
morluto merged commit 2895a18 into main Oct 13, 2026
3 checks passed
@morluto
morluto deleted the codex/ci-skip-portable-merge-after-skipped-shards branch October 13, 2026 18:30
@morluto morluto added bug Something isn't working area: native Native analysis and decompilation, including Ghidra, IDA, and Hopper analysis behavior labels Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: native Native analysis and decompilation, including Ghidra, IDA, and Hopper analysis behavior bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant