Skip to content

Conversation

@peteski22
Copy link
Contributor

What's changing

  • Remove the boto dependency
  • Use s3fs as a replacement (presigned urls and listing files)
  • Now requires some asynchronous calls
  • Updated tests

Closes #473

How to test it

Steps to test the changes:

Additional notes for reviewers

Anything you'd like to add to help the reviewer understand the changes you're proposing.

I already...

  • Tested the changes in a working environment to ensure they work as expected
  • Added some tests for any new functionality
  • Updated the documentation (both comments in code and product documentation under /docs)
  • Checked if a (backend) DB migration step was required and included it if required

@peteski22 peteski22 requested a review from javiermtorres March 20, 2025 12:55
@github-actions github-actions bot added sdk backend api Changes which impact API/presentation layer schemas Changes to schemas (which may be public facing) labels Mar 20, 2025
@peteski22 peteski22 mentioned this pull request Mar 21, 2025
4 tasks
@peteski22 peteski22 enabled auto-merge (squash) March 21, 2025 12:41
@peteski22 peteski22 merged commit 815f925 into main Mar 21, 2025
19 of 21 checks passed
@peteski22 peteski22 deleted the peteski22/473/remove-s3-boto-deps branch March 21, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Changes which impact API/presentation layer backend schemas Changes to schemas (which may be public facing) sdk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Using two implementations of botocore to connect to S3

3 participants