Skip to content

Fix async issues after moving to S3FileSystem from boto3 client #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
peteski22 merged 1 commit into from
Mar 26, 2025
Merged

Fix async issues after moving to S3FileSystem from boto3 client #1288

peteski22 merged 1 commit into from
Mar 26, 2025

Conversation

@peteski22
Copy link
Contributor

@peteski22 peteski22 commented Mar 26, 2025 •
edited
Loading

What's changing

Provide a clear and concise description of the content changes you're proposing. List all the
changes you are making to the content.

  • Update the Tracking Client interface to be async for all methods by default
  • Update MLFlow Tracking Client to adhere to the updated interface
  • Bubble up async calls through services and routes (workflows, experiments)
  • Configure S3FileSystem used for tests (via MagicMock) to emulate the correct params for 'storage_options'
  • Remove un-required (s3 related) dependencies, and update dependencies from backend's pyproject.toml
  • Fix: Add 'integration' pytest marker to test config to prevent warnings being emitted during test runs
  • Chore: uv.lock updated

Refs: #1252

How to test it

Steps to test the changes:

Additional notes for reviewers

Anything you'd like to add to help the reviewer understand the changes you're proposing.

I already...

  • Tested the changes in a working environment to ensure they work as expected
  • Added some tests for any new functionality
  • Updated the documentation (both comments in code and product documentation under /docs)
  • Checked if a (backend) DB migration step was required and included it if required

@github-actions github-actions bot added dependencies Pull requests that update a dependency file backend api Changes which impact API/presentation layer labels Mar 26, 2025
@peteski22
Fix async issues after moving to S3FileSystem from boto3 client
8b07c31 
* Update the Tracking Client interface to be async for all methods by default
* Update MLFlow Tracking Client to adhere to the updated interface
* Bubble up async calls through services and routes (workflows, experiments)
* Configure S3FileSystem used for tests (via MagicMock) to emulate the correct params for 'storage_options'
* Remove un-required (s3 related) dependencies, and update dependencies from backend's pyproject.toml
* Fix: Add 'integration' pytest marker to test config to prevent warnings being emitted during test runs
* Chore: uv.lock updated
@peteski22 peteski22 force-pushed the s3/update-async-methods branch from 0024577 to 8b07c31 Compare March 26, 2025 12:18
@peteski22 peteski22 enabled auto-merge (squash) March 26, 2025 12:20
@peteski22 peteski22 requested a review from javiermtorres March 26, 2025 12:20
@peteski22 peteski22 merged commit 64fd1ea into main Mar 26, 2025
22 checks passed
@peteski22 peteski22 deleted the s3/update-async-methods branch March 26, 2025 13:00
@peteski22 peteski22 mentioned this pull request Apr 7, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiermtorres javiermtorres javiermtorres approved these changes

Assignees

No one assigned

Labels

api Changes which impact API/presentation layer backend dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peteski22 @javiermtorres