This repository was archived by the owner on May 22, 2021. It is now read-only.
Add possibility to bind to a specific IP address#668
Merged
dannycoates merged 4 commits intomozilla:masterfrom Dec 21, 2017
TwizzyDizzy:master
Merged
Add possibility to bind to a specific IP address#668dannycoates merged 4 commits intomozilla:masterfrom TwizzyDizzy:master
dannycoates merged 4 commits intomozilla:masterfrom
TwizzyDizzy:master
Conversation
added 2 commits
December 9, 2017 02:21
The IP address to bind the HTTP server to
Closed
dannycoates
suggested changes
Dec 21, 2017
Contributor
dannycoates
left a comment
dannycoates
left a comment
There was a problem hiding this comment.
This looks great! Just one tiny change before we merge.
server/config.js
Outdated
| }, | ||
| listen_address: { | ||
| format: 'ipaddress', | ||
| default: '127.0.0.1', |
Contributor
There was a problem hiding this comment.
Let's make the default '0.0.0.0' so that it will listen on all addresses
Author
|
Changed as requested, though in real-life you'd want to reverse proxy mozilla send (that's why I deemed 127.0.0.1 to be the wiser default) Cheers |
Contributor
|
Thank you @TwizzyDizzy 😄 |
Author
|
Closing, since merged to master. Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.