Skip to content
This repository was archived by the owner on May 22, 2021. It is now read-only.

Add possibility to bind to a specific IP address #668

Merged
dannycoates merged 4 commits into from
Dec 21, 2017
Merged

Add possibility to bind to a specific IP address #668

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
106aef5
Add new config item: listen_address
Dec 9, 2017
c8e168a
Use new config item 'listen_address' in prod
Dec 9, 2017
b80ee8d
Make the linter happy :)
Dec 9, 2017
6f27c6e
Change default bind address to 0.0.0.0
Dec 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions server/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ const conf = convict({
default: 'localhost',
env: 'REDIS_HOST'
},
listen_address: {
format: 'ipaddress',
default: '127.0.0.1',
Copy link
Copy Markdown
Contributor

@dannycoates dannycoates Dec 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make the default '0.0.0.0' so that it will listen on all addresses

env: 'IP_ADDRESS'
},
listen_port: {
format: 'port',
default: 1443,
Expand Down
2 changes: 1 addition & 1 deletion server/prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ app.use(

app.use(pages.notfound);

app.listen(config.listen_port);
app.listen(config.listen_port,config.listen_address);