Skip to content
This repository was archived by the owner on May 22, 2021. It is now read-only.

changed font to sans sherif: Solves #676#679

Merged
dannycoates merged 1 commit into
mozilla:masterfrom
shikhar-scs:master
Jan 8, 2018
Merged

changed font to sans sherif: Solves #676#679
dannycoates merged 1 commit into
mozilla:masterfrom
shikhar-scs:master

Conversation

@shikhar-scs

Copy link
Copy Markdown
Contributor

The font as marked out by @johngruen in #676 was different (Fira sans) and it has now been set to Sans sherif as required.

@shikhar-scs

Copy link
Copy Markdown
Contributor Author

@sevaan Please have a look at this. Do I need to change anything else too.

@sevaan

sevaan commented Dec 23, 2017

Copy link
Copy Markdown

It's sans-serif, not sans sherif.

Plus, I believe there is some alternate font information missing (redundancies, etc). I can see it when I view other text on the site in inspector. @dannycoates might be able to provide the missing info.

@shikhar-scs

Copy link
Copy Markdown
Contributor Author

ohk I'll have a look and revert back here

@shikhar-scs

Copy link
Copy Markdown
Contributor Author

@sevaan

what I've noticed is that 'SF Pro Text', sans-serif and 'Segoe UI', 'SF Pro Text', sans-serif have been used alternatively in the main.css file and so for the time being I've used 'SF Pro Text', sans-serif. However, if the latter is required to be used then I'll do that accordingly.
Also, once the PR gets reviewed, I'll squash my commits too :)

@shikhar-scs

shikhar-scs commented Jan 2, 2018

Copy link
Copy Markdown
Contributor Author

@sevaan @dannycoates @johngruen do you mind giving a review?

@dannycoates dannycoates left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be:

font-family: 'Fira Sans', 'segoe ui', sans-serif;

and also applied to #dl-firefox, #update-firefox

@shikhar-scs

Copy link
Copy Markdown
Contributor Author

font-family: 'Fira Sans', 'segoe ui', sans-serif;
and also applied to #dl-firefox, #update-firefox

I'll do that rightaway

improved font family

font changes
@dannycoates dannycoates merged commit 3d48ea7 into mozilla:master Jan 8, 2018
@dannycoates

Copy link
Copy Markdown
Contributor

Thanks @shikhar-scs 😄

@shikhar-scs

Copy link
Copy Markdown
Contributor Author

Welcome @dannycoates

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants