This repository was archived by the owner on May 22, 2021. It is now read-only.
checkbox now has a hover effect: fixes #635#685
Merged
dannycoates merged 1 commit intomozilla:masterfrom Jan 3, 2018
Merged
Conversation
Contributor
|
This looks good to me. Thank you @himanish-star 😄 |
Contributor
Author
|
@dannycoates , if it's okay with you, could you also review #684 and #694 |
Contributor
|
Also @dannycoates please go for #695 #686 #681 #679 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes; #635
@SoftVision-CosminMuntean , is this what you wanted ?
@dannycoates thanks for the help. Actually I was trying to hover the check sign inside the checkbox that is why I was stuck over the issue of mouse event listeners
changes are as follows