Fix warnings introduced by latest React canary #35987
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Jan 29, 2023
Comment on lines
-522
to
-533
| this.assert( | ||
| expectedMessages.length > 0, | ||
| `Expected to call console.${methodName} but didn't provide messages. ` + | ||
| `If you don't expect any messages prefer \`expect().not.${matcherName}();\`.`, | ||
| `Expected no call to console.${methodName} while also expecting messages.` + | ||
| 'Expected no call to console.error but provided messages. ' + | ||
| "If you want to make sure a certain message isn't logged prefer the positive. " + | ||
| 'By expecting certain messages you automatically expect that no other messages are logged', | ||
| // Not interested in a diff but the typings require the 4th parameter. | ||
| undefined, | ||
| ); | ||
|
|
Member
Author
There was a problem hiding this comment.
Would be annoying to handle code that only warns in specific React versions.
eps1lon
added
test
scope: autocomplete
Netlify deploy previewhttps://deploy-preview-35987--material-ui.netlify.app/ Bundle size report |
github-actions
bot
added
the
PR: out-of-date
…ontrolled components
eps1lon
force-pushed
the
test/react-next
branch
from
1c52c29 to
d2ff138
Compare
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would recommend splitting these out into individual PRs since some changes affect shipped code. I won't have the time to do that though but it should be straig forward since I handled different warnings in different commits.
Notable React canary changes are the introduction of warnings for usage of
defaultPropsand spreadingkey(part of reactjs/rfcs#107)Part of #14761