Skip to content

Fix warnings introduced by latest React canary #35987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Fix warnings introduced by latest React canary #35987

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2a8cd66
Install react@next
eps1lon Jan 28, 2023
b40a202
Fix false-positive warning about switching between controlled and unc…
eps1lon Jan 29, 2023
adb017b
test: Handle .defaultProps warnings
eps1lon Jan 29, 2023
5d90158
[Autocomplete] Stop spreading `key`
eps1lon Jan 29, 2023
2cb2097
test: Handle unknown change to render/effect invocation count
eps1lon Jan 29, 2023
8b72d7c
Fix Tabs test in Node 18.15.0
eps1lon Apr 16, 2023
c20ad67
f
eps1lon Apr 16, 2023
93d9c95
Work around facebook/react#26113
eps1lon Apr 16, 2023
d2ff138
Use latest canary
eps1lon Apr 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Tabs test in Node 18.15.0
  • Loading branch information
@eps1lon
eps1lon committed Apr 16, 2023
commit 8b72d7c89d0ca39fb0d8b0c0838425fd896a265d
14 changes: 12 additions & 2 deletions packages/mui-material-next/src/Tabs/Tabs.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,11 +338,21 @@ describe('<Tabs />', () => {

nodeEnv = process.env.NODE_ENV;
// We can't use a regular assignment, because it causes a syntax error in Karma
Object.defineProperty(process.env, 'NODE_ENV', { value: 'development' });
Object.defineProperty(process.env, 'NODE_ENV', {
configurable: true,
writable: true,
enumerable: true,
value: 'development',
});
});

after(() => {
Object.defineProperty(process.env, 'NODE_ENV', { value: nodeEnv });
Object.defineProperty(process.env, 'NODE_ENV', {
configurable: true,
writable: true,
enumerable: true,
value: nodeEnv,
});
});

it('should warn if a Tab has display: none', () => {
Expand Down