Skip to content

[blog] Add post about how MUI uses Toolpad #40172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
prakhargupta1 merged 41 commits into from
Mar 4, 2024
Merged

[blog] Add post about how MUI uses Toolpad #40172

prakhargupta1 merged 41 commits into from
Mar 4, 2024

Conversation

@prakhargupta1
Copy link
Member

@prakhargupta1 prakhargupta1 commented Dec 11, 2023 •
edited
Loading

@prakhargupta1 prakhargupta1 added the blog Related to blog content or publication. label Dec 11, 2023
@mui-bot
Copy link

mui-bot commented Dec 11, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-40172--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 1460deb

@danilo-leal danilo-leal changed the title Add Toolpad blog: How MUI uses Toolpad. [blog] Add post about how MUI uses Toolpad Dec 11, 2023
@prakhargupta1 prakhargupta1 marked this pull request as ready for review January 9, 2024 07:00
bharatkashyap
bharatkashyap reviewed Jan 9, 2024
View reviewed changes
@prakhargupta1 @bharatkashyap
Update docs/pages/blog/2023-toolpad-usage-in-mui.md
b7c4300 
Co-authored-by: Bharat Kashyap <[email protected]>
Signed-off-by: Prakhar Gupta <[email protected]>
mapache-salvaje
mapache-salvaje reviewed Jan 17, 2024
View reviewed changes
mapache-salvaje
mapache-salvaje reviewed Feb 19, 2024
View reviewed changes
Copy link
Contributor

@mapache-salvaje mapache-salvaje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice piece! One last nitpick: I'd drop the year from the file names. Maybe rename to something like toolpad-use-cases to try to get a little bit of SEO in the slug.

mapache-salvaje
mapache-salvaje reviewed Feb 23, 2024
View reviewed changes
Copy link
Contributor

@mapache-salvaje mapache-salvaje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid progress—almost there!

@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 23, 2024

Rebased on HEAD and fixed the build.

@oliviertassinari oliviertassinari force-pushed the blog-how-mui-uses-toolpad branch from 1dfce5d to c7f1f01 Compare February 23, 2024 22:52
oliviertassinari
oliviertassinari reviewed Feb 23, 2024
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me 👍

@oliviertassinari oliviertassinari force-pushed the blog-how-mui-uses-toolpad branch from 3ed2ca7 to bd4faa2 Compare February 26, 2024 00:58
@prakhargupta1
Copy link
Member Author

prakhargupta1 commented Feb 29, 2024

I see Danilo mentioned about the failing tests on some of his PRs. I am assuming this PR falls in the same bucket.
Bringing this to your notice @Janpot. Thanks.

bharatkashyap
bharatkashyap approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@bharatkashyap bharatkashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! Solid content.

@prakhargupta1 prakhargupta1 enabled auto-merge (squash) March 4, 2024 14:37
@prakhargupta1 prakhargupta1 merged commit f58d02e into mui:master Mar 4, 2024
@prakhargupta1 prakhargupta1 deleted the blog-how-mui-uses-toolpad branch March 4, 2024 14:51
Janpot
Janpot reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@danilo-leal
Copy link
Collaborator

danilo-leal commented Mar 4, 2024

We just missed uptading the publishing date, though, it's set to Sunday, March 3th. 😬 Not a big deal, we can adjust it later!

@prakhargupta1
Copy link
Member Author

prakhargupta1 commented Mar 4, 2024

We just missed uptading the publishing date, though, it's set to Sunday, March 3th. 😬 Not a big deal, we can adjust it later!

Screenshot 2024-03-04 at 9 06 47 PM

It's 4th March, today. Are we checking the same date? 😅

@danilo-leal
Copy link
Collaborator

danilo-leal commented Mar 4, 2024

Huh, weird, I see Sunday 😅 Maybe it's timezone-related somehow?

Screenshot 2024-03-04 at 12 55 29

@Janpot Janpot mentioned this pull request Mar 4, 2024
Merged
@mapache-salvaje
Copy link
Contributor

mapache-salvaje commented Mar 4, 2024

Maybe it's timezone-related somehow?

Yep, I think the T00:00:00.000Z time in the date applies to UTC+00:00, which translates to the day before for those of us to the west of the international date line.

mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
@prakhargupta1 @bharatkashyap
@mapache-salvaje @oliviertassinari @danilo-leal @Janpot @mnajdova
[blog] Add post about how MUI uses Toolpad (mui#40172)
1b9e0d2 
Signed-off-by: Prakhar Gupta <[email protected]>
Signed-off-by: Olivier Tassinari <[email protected]>
Co-authored-by: Bharat Kashyap <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Co-authored-by: Olivier Tassinari <[email protected]>
Co-authored-by: Danilo Leal <[email protected]>
Co-authored-by: MUI bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Janpot Janpot Janpot left review comments

@mapache-salvaje mapache-salvaje mapache-salvaje left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

+2 more reviewers

@danilo-leal danilo-leal danilo-leal left review comments

@bharatkashyap bharatkashyap bharatkashyap approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

blog Related to blog content or publication.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@prakhargupta1 @mui-bot @oliviertassinari @danilo-leal @mapache-salvaje @Janpot @bharatkashyap