Skip to content

[material-ui] Support props callback type in theme variants #40946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ZeeshanTamboli merged 5 commits into from
Mar 2, 2024
Merged

[material-ui] Support props callback type in theme variants #40946

ZeeshanTamboli merged 5 commits into from
Mar 2, 2024

Conversation

@ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Feb 5, 2024 •
edited
Loading

@ZeeshanTamboli ZeeshanTamboli added type: bug It doesn't behave as expected. typescript package: material-ui customization: theme Higher level theming customizability. labels Feb 5, 2024
@mui-bot
Copy link

mui-bot commented Feb 5, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-40946--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 5c773ad

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review February 5, 2024 07:48
@ZeeshanTamboli
Copy link
Member Author

ZeeshanTamboli commented Feb 16, 2024

Can this be reviewed?

@ZeeshanTamboli
Copy link
Member Author

ZeeshanTamboli commented Feb 28, 2024 •
edited
Loading

Can this be reviewed? @siriwatknp @brijeshb42 @mnajdova

siriwatknp
siriwatknp reviewed Mar 1, 2024
View reviewed changes
siriwatknp
siriwatknp approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment before merging. 👍

@ZeeshanTamboli ZeeshanTamboli merged commit 6d168ac into mui:master Mar 2, 2024
@ZeeshanTamboli ZeeshanTamboli deleted the fix-40671-variants-callback-typescript branch March 2, 2024 10:28
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
@ZeeshanTamboli @mnajdova
[material-ui] Support props callback type in theme variants (mui#40946)
fc04d35
@LukasTy LukasTy mentioned this pull request Mar 15, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@brijeshb42 brijeshb42 Awaiting requested review from brijeshb42

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees

No one assigned

Labels

customization: theme Higher level theming customizability. type: bug It doesn't behave as expected. typescript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[material-ui] Using variant props callback errors in TypeScript

3 participants

@ZeeshanTamboli @mui-bot @siriwatknp